Skip to content

Feature/fuzzy match#213

Open
bidhan-nagarro wants to merge 22 commits intomainfrom
feature/fuzzy-match
Open

Feature/fuzzy match#213
bidhan-nagarro wants to merge 22 commits intomainfrom
feature/fuzzy-match

Conversation

@bidhan-nagarro
Copy link
Copy Markdown
Collaborator

@bidhan-nagarro bidhan-nagarro commented Mar 11, 2026

What type of PR is this?

  • feat: Commits that add a new feature

Summary

What does this PR do

This PR add a new api where the fuzzy matching of the column values would be done when a file is uploaded from the sync.

Copy link
Copy Markdown
Collaborator

@Javiershenbc Javiershenbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are issues in the matching logic. Some values seem to be incorrectly locked or replaced with non exact matches, whereas they should only be matched exactly.

If this behavior is due to values being locked once a match is found and therefore not updated afterwards, it would be clearer to set the dropdown selection explicitly to the matched value. This would help avoid confusion and make the behavior more predictable.

Image Image

@bidhan-nagarro
Copy link
Copy Markdown
Collaborator Author

There are issues in the matching logic. Some values seem to be incorrectly locked or replaced with non exact matches, whereas they should only be matched exactly.

If this behavior is due to values being locked once a match is found and therefore not updated afterwards, it would be clearer to set the dropdown selection explicitly to the matched value. This would help avoid confusion and make the behavior more predictable.

Image Image

@Javiershenbc have pushed the fixes. Test and let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants