AB#241796: Add cache for Kobo data#65
Merged
sergey-misuk-valor merged 5 commits intodevelopfrom Apr 3, 2025
Merged
Conversation
41ce9a8 to
524dcaa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #65 +/- ##
===========================================
+ Coverage 92.92% 92.98% +0.06%
===========================================
Files 156 156
Lines 4637 4678 +41
Branches 403 405 +2
===========================================
+ Hits 4309 4350 +41
Misses 223 223
Partials 105 105 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
domdinicola
reviewed
Apr 3, 2025
| return f"dg:{url}" | ||
|
|
||
|
|
||
| class DataGetter: |
Collaborator
There was a problem hiding this comment.
can we have a more intuitive name?
Contributor
Author
There was a problem hiding this comment.
@domdinicola Does HttpDataGetter sound better?
Collaborator
There was a problem hiding this comment.
ok, would be good if we add docstrings to classes
domdinicola
approved these changes
Apr 3, 2025
vitali-yanushchyk-valor
approved these changes
Apr 3, 2025
Collaborator
|
@sergey-misuk-im test failing |
Contributor
Author
Yes, I know, there were few failures related to docker hub, and the last two related to few tests that periodically fail because of some concurrency issues I guess. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legal Boilerplate
Look, I get it.
Contributing to HOPE Workspace, I retain all rights, title and interest in and to my contributions, and by keeping
this boilerplate intact I confirm that HOPE Workspace can use, modify, copy, and redistribute my contributions,
under HOPE's choice of terms.