Skip to content

AB#241796: Add cache for Kobo data#65

Merged
sergey-misuk-valor merged 5 commits intodevelopfrom
feature/241796-add-cache-on-projects-for-kobo
Apr 3, 2025
Merged

AB#241796: Add cache for Kobo data#65
sergey-misuk-valor merged 5 commits intodevelopfrom
feature/241796-add-cache-on-projects-for-kobo

Conversation

@sergey-misuk-valor
Copy link
Contributor

Legal Boilerplate

Look, I get it.
Contributing to HOPE Workspace, I retain all rights, title and interest in and to my contributions, and by keeping
this boilerplate intact I confirm that HOPE Workspace can use, modify, copy, and redistribute my contributions,
under HOPE's choice of terms.

@sergey-misuk-valor sergey-misuk-valor force-pushed the feature/241796-add-cache-on-projects-for-kobo branch from 41ce9a8 to 524dcaa Compare April 3, 2025 05:52
@codecov
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.98%. Comparing base (8387600) to head (b6b8872).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #65      +/-   ##
===========================================
+ Coverage    92.92%   92.98%   +0.06%     
===========================================
  Files          156      156              
  Lines         4637     4678      +41     
  Branches       403      405       +2     
===========================================
+ Hits          4309     4350      +41     
  Misses         223      223              
  Partials       105      105              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

return f"dg:{url}"


class DataGetter:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have a more intuitive name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@domdinicola Does HttpDataGetter sound better?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, would be good if we add docstrings to classes

@domdinicola
Copy link
Collaborator

@sergey-misuk-im test failing

@sergey-misuk-valor
Copy link
Contributor Author

@sergey-misuk-im test failing

Yes, I know, there were few failures related to docker hub, and the last two related to few tests that periodically fail because of some concurrency issues I guess.

@sergey-misuk-valor sergey-misuk-valor merged commit ebf2ef3 into develop Apr 3, 2025
10 checks passed
@sergey-misuk-valor sergey-misuk-valor deleted the feature/241796-add-cache-on-projects-for-kobo branch April 3, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments