Skip to content

AB#241769: add ! beneficiary_group#60

Merged
vitali-yanushchyk-valor merged 2 commits intodevelopfrom
feature/241769-beneficiary-group-sync
Mar 25, 2025
Merged

AB#241769: add ! beneficiary_group#60
vitali-yanushchyk-valor merged 2 commits intodevelopfrom
feature/241769-beneficiary-group-sync

Conversation

@vitali-yanushchyk-valor
Copy link
Contributor

Legal Boilerplate

Look, I get it.
Contributing to HOPE Workspace, I retain all rights, title and interest in and to my contributions, and by keeping
this boilerplate intact I confirm that HOPE Workspace can use, modify, copy, and redistribute my contributions,
under HOPE's choice of terms.

@vitali-yanushchyk-valor vitali-yanushchyk-valor force-pushed the feature/241769-beneficiary-group-sync branch 3 times, most recently from ce5ffe6 to 67f7bf2 Compare March 24, 2025 12:33
@vitali-yanushchyk-valor vitali-yanushchyk-valor force-pushed the feature/241769-beneficiary-group-sync branch from 67f7bf2 to 5ed4ca9 Compare March 24, 2025 13:44
@codecov
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 98.64865% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.78%. Comparing base (22ef82c) to head (a2ea1e4).
Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
src/country_workspace/workspaces/sites.py 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #60      +/-   ##
===========================================
+ Coverage    92.40%   92.78%   +0.38%     
===========================================
  Files          152      154       +2     
  Lines         4466     4535      +69     
  Branches       389      395       +6     
===========================================
+ Hits          4127     4208      +81     
+ Misses         236      225      -11     
+ Partials       103      102       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vitali-yanushchyk-valor vitali-yanushchyk-valor marked this pull request as ready for review March 24, 2025 14:03
if record["status"] not in [Program.ACTIVE, Program.DRAFT]:
continue
# TODO: beneficiary group - choose from the REST API when it will be available
beneficiary_group = BeneficiaryGroup.objects.first()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls address the todo! @vitali-yanushchyk-valor

@vitali-yanushchyk-valor vitali-yanushchyk-valor added the db migration Database migration updates are present. label Mar 25, 2025
@vitali-yanushchyk-valor vitali-yanushchyk-valor merged commit 69a13ba into develop Mar 25, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

db migration Database migration updates are present.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments