AB#241769: add ! beneficiary_group#60
Merged
vitali-yanushchyk-valor merged 2 commits intodevelopfrom Mar 25, 2025
Merged
Conversation
ce5ffe6 to
67f7bf2
Compare
67f7bf2 to
5ed4ca9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #60 +/- ##
===========================================
+ Coverage 92.40% 92.78% +0.38%
===========================================
Files 152 154 +2
Lines 4466 4535 +69
Branches 389 395 +6
===========================================
+ Hits 4127 4208 +81
+ Misses 236 225 -11
+ Partials 103 102 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sergey-misuk-valor
approved these changes
Mar 24, 2025
domdinicola
approved these changes
Mar 25, 2025
domdinicola
reviewed
Mar 25, 2025
| if record["status"] not in [Program.ACTIVE, Program.DRAFT]: | ||
| continue | ||
| # TODO: beneficiary group - choose from the REST API when it will be available | ||
| beneficiary_group = BeneficiaryGroup.objects.first() |
Collaborator
There was a problem hiding this comment.
pls address the todo! @vitali-yanushchyk-valor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legal Boilerplate
Look, I get it.
Contributing to HOPE Workspace, I retain all rights, title and interest in and to my contributions, and by keeping
this boilerplate intact I confirm that HOPE Workspace can use, modify, copy, and redistribute my contributions,
under HOPE's choice of terms.