[AB#307495]-setup selenium base + add create program test#5853
Open
[AB#307495]-setup selenium base + add create program test#5853
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5853 +/- ##
========================================
Coverage 92.26% 92.26%
========================================
Files 494 494
Lines 34360 34360
Branches 3603 3603
========================================
Hits 31703 31703
Misses 1908 1908
Partials 749 749
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Jeeziorny
reviewed
Mar 30, 2026
Jeeziorny
reviewed
Mar 30, 2026
saxix
requested changes
Mar 31, 2026
Member
saxix
left a comment
saxix
left a comment
There was a problem hiding this comment.
as general consideration, use browser instead of sb
Jeeziorny
reviewed
Apr 1, 2026
Jeeziorny
reviewed
Apr 1, 2026
Jeeziorny
reviewed
Apr 1, 2026
Jeeziorny
reviewed
Apr 1, 2026
johniak
requested changes
Apr 1, 2026
Jeeziorny
requested changes
Apr 10, 2026
domdinicola
reviewed
Apr 10, 2026
|
|
||
| [tool.uv] | ||
| override-dependencies = [ | ||
| "pytest-html==4.0.2", |
Contributor
There was a problem hiding this comment.
i'm not a fan of these overrides
Contributor
Author
There was a problem hiding this comment.
@domdinicola Me neither, but here is the reason why.
seleniumbase/SeleniumBase#3619
Jeeziorny
approved these changes
Apr 12, 2026
| pytestmark = pytest.mark.django_db() | ||
|
|
||
| # --------------------------------------------------------------------------- | ||
| # Selectors – Programme Management wizard (3-step) |
Contributor
There was a problem hiding this comment.
I think those comments with -------- are unnecessary. What do you think?
remove needless comments in test_create_program
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AB#307495