Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5871 +/- ##
========================================
Coverage 92.25% 92.25%
========================================
Files 494 494
Lines 34349 34355 +6
Branches 3602 3602
========================================
+ Hits 31688 31694 +6
Misses 1911 1911
Partials 750 750
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Conflicts: # src/hope/apps/household/migrations/0036_migration.py
MarekBiczysko
approved these changes
Apr 9, 2026
Jeeziorny
approved these changes
Apr 9, 2026
domdinicola
reviewed
Apr 9, 2026
domdinicola
reviewed
Apr 9, 2026
domdinicola
reviewed
Apr 9, 2026
domdinicola
reviewed
Apr 9, 2026
domdinicola
reviewed
Apr 9, 2026
domdinicola
requested changes
Apr 9, 2026
domdinicola
reviewed
Apr 9, 2026
domdinicola
reviewed
Apr 9, 2026
domdinicola
reviewed
Apr 9, 2026
domdinicola
requested changes
Apr 9, 2026
Contributor
domdinicola
left a comment
domdinicola
left a comment
There was a problem hiding this comment.
is root should not be removed at the moment
remove use of "can_" because is not consistent
if single or not, we use the same permission
domdinicola
requested changes
Apr 15, 2026
| return TemplateResponse(request, "core/test_rapidpro.html", context) | ||
|
|
||
| @button(permission=is_root) | ||
| @button(permission=lambda request, obj, handler: is_root(request) or request.user.has_perm("core.mark_submissions")) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AB#305575: admin buttons permissions