Merged
Conversation
domdinicola
force-pushed
the
feature/fix-aurora-clean-task
branch
from
94886b4 to
1742acf
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5897 +/- ##
===========================================
+ Coverage 92.25% 92.26% +0.01%
===========================================
Files 494 494
Lines 34349 34361 +12
Branches 3602 3603 +1
===========================================
+ Hits 31688 31703 +15
+ Misses 1911 1908 -3
Partials 750 750
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
domdinicola
requested review from
Jeeziorny,
MarekBiczysko,
johniak,
pavlo-mk and
pkujawa
Contributor
|
Do we have task for that on AB? |
Jeeziorny
reviewed
Apr 12, 2026
| @sentry_tags | ||
| def clean_old_record_files_task() -> None: | ||
| def clean_old_record_files_task(batch_size: int = 100) -> None: | ||
| """Task to clean (sets to null) Record's files field.""" |
Contributor
There was a problem hiding this comment.
Is it setting to null or removing records?
johniak
requested changes
Apr 13, 2026
| @sentry_tags | ||
| def clean_old_record_files_task() -> None: | ||
| def clean_old_record_files_task(batch_size: int = 100) -> None: | ||
| """Task to clean (sets to null) Record's files field.""" |
Contributor
There was a problem hiding this comment.
Docstring is inconsistent with the code (deletes, not "sets to null"). Update to: "Task to delete old imported Records."
domdinicola
force-pushed
the
feature/fix-aurora-clean-task
branch
2 times, most recently
from
12bc1b4 to
bb85190
Compare
domdinicola
force-pushed
the
feature/fix-aurora-clean-task
branch
from
bb85190 to
76a9d4f
Compare
MarekBiczysko
approved these changes
Apr 14, 2026
domdinicola
force-pushed
the
feature/fix-aurora-clean-task
branch
from
76a9d4f to
bebe52d
Compare
pavlo-mk
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the task kills the pod because of out of memory
AB#310005