Open
Conversation
added 2 commits
April 13, 2026 14:53
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5902 +/- ##
===========================================
+ Coverage 92.25% 92.29% +0.04%
===========================================
Files 494 494
Lines 34349 34372 +23
Branches 3602 3604 +2
===========================================
+ Hits 31689 31725 +36
+ Misses 1911 1899 -12
+ Partials 749 748 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Jeeziorny
reviewed
Apr 14, 2026
|
|
||
| def test_clean_old_record_files_task(record_set: dict[str, Record]) -> None: | ||
| clean_old_record_files_task() | ||
| queue_and_run_async_task(clean_old_record_files_async_task) |
Jeeziorny
reviewed
Apr 14, 2026
| ) | ||
|
|
||
|
|
||
| def queue_and_run_async_task(task: object, *args: object, **kwargs: object) -> object: |
Contributor
There was a problem hiding this comment.
It's a duplicate. Can't we put this function to fixture and put it to conftest, so that we keep it dry?
Jeeziorny
reviewed
Apr 14, 2026
| def test_create_task_for_processing_records_not_implemented_error() -> None: | ||
| with pytest.raises(NotImplementedError): | ||
| create_task_for_processing_records(ServiceWithoutCeleryTask, uuid.uuid4(), uuid.uuid4(), [1]) | ||
| create_task_for_processing_records(ServiceWithoutCeleryTask, None, None, [1]) |
Contributor
There was a problem hiding this comment.
Do you have any thoughts against adding assertion for number of db queries made for those tests? If not, can we add it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AB#307726