Migrations regeneration api types precommit#5917
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5917 +/- ##
========================================
Coverage 92.28% 92.28%
========================================
Files 494 494
Lines 34362 34362
Branches 3603 3603
========================================
Hits 31711 31711
Misses 1904 1904
Partials 747 747
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Jeeziorny
requested review from
MarekBiczysko,
domdinicola,
johniak and
pkujawa
domdinicola
reviewed
Apr 20, 2026
| @@ -0,0 +1,45 @@ | |||
| #!/usr/bin/env bash | |||
Contributor
There was a problem hiding this comment.
interesting we need to check FE types...
Contributor
Author
There was a problem hiding this comment.
I don't understand what action this comment require
Contributor
There was a problem hiding this comment.
what is the idea of this hook?
domdinicola
reviewed
Apr 20, 2026
| # than its directory name, add an explicit mapping here. | ||
|
|
||
| set -euo pipefail | ||
|
|
Contributor
There was a problem hiding this comment.
I think we can reuse something
repos:
-
repo: local
hooks:- id: django-migrations-check
name: Check for missing Django migrations
entry: python manage.py makemigrations --check --dry-run
language: system
pass_filenames: false
- id: django-migrations-check
-
repo: https://github.com/ecugol/pre-commit-hooks-django
rev: v0.4.0
hooks:- id: check-absent-migrations
@saxix ?
domdinicola
requested changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently I got a few issues bc I forgot to commit django migration files and/or REST API Types. Changes on this branch introduce precommit checks: