Code updates for latest changes by martti007 · Pull Request #3 · unicitynetwork/state-transition-sdk-java

martti007 · 2025-08-19T07:49:37Z

No description provided.

MastaP · 2025-08-22T16:17:14Z

+    // Alice transfers to Bob
+    String bobCustomData = "Bob's custom data";
+    byte[] bobStateData = bobCustomData.getBytes(StandardCharsets.UTF_8);
+    DataHash bobDataHash = new DataHasher(HashAlgorithm.SHA256).update(bobStateData).digest();


how does Alice know Bob's custom data or its hash?

MastaP · 2025-08-22T16:22:51Z

+
+  public <T extends MintTransactionData<?>> CompletableFuture<SubmitCommitmentResponse> submitCommitment(
+      MintCommitment<T> commitment) {
+    return this.client.submitCommitment(


aggregator client coult simply take Commitment object as input, MintCommitment and TransferCommitment both extend it. TransactionData could know how to calculate its own hash (MintTransactionData already does) and TransferTransactionData has all the token info it needs at creation time.

MastaP · 2025-08-22T16:27:20Z

+    return token.update(state, transaction, nametagTokens);
+  }
+
+  public CompletableFuture<InclusionProofVerificationStatus> getTokenStatus(


unused, needs tests

MastaP · 2025-08-22T16:31:03Z

+import java.util.Objects;
+
+/**
+ * Direct address implementation


MastaP · 2025-08-22T17:13:31Z

-}
+  public MaskedPredicate(
+      byte[] publicKey,
+      String algorithm,


unclear what algorithm

MastaP · 2025-08-22T17:50:39Z

+
+    // Extract algorithm from first two bytes
+    int algorithmValue = ((imprint[0] & 0xFF) << 8) | (imprint[1] & 0xFF);
+    HashAlgorithm algorithm = HashAlgorithm.values()[algorithmValue];


potential ArrayIndexOutOfBoundsException

MastaP · 2025-08-22T17:58:37Z

+      return false;
+    }
+    DirectAddress that = (DirectAddress) o;
+    return Objects.equals(data, that.data) && Objects.deepEquals(checksum,


why not Arrays.equals instead of deepEquals

MastaP · 2025-08-22T17:58:50Z

+      return false;
+    }
+    ProxyAddress that = (ProxyAddress) o;
+    return Objects.equals(data, that.data) && Objects.deepEquals(checksum,


Arrays.equals

Copilot

Pull Request Overview

This is a comprehensive refactoring PR that updates the codebase to align with the latest changes across multiple components. It includes significant restructuring of the core SDK classes and removal of outdated test files.

Key changes:

Complete refactoring of hash, transaction, token, and predicate classes to remove dependencies on async patterns and outdated interfaces
Removal of numerous test files that appear to be outdated or duplicated
Addition of new core utilities like BitString, VerificationResult, and split transaction functionality
Migration from ISerializable interface to more specific transaction data interfaces

Reviewed Changes

Copilot reviewed 272 out of 283 changed files in this pull request and generated 3 comments.

File	Description
Test files (removed)	Cleanup of outdated test infrastructure including JSONRPC, CBOR, and hash-related tests
New test files	Addition of comprehensive tests for core functionality including Merkle trees, API components, and E2E flows
Core SDK refactoring	Complete overhaul of transaction, token, and utility classes with new verification patterns
New utilities	Introduction of `BitString`, `VerificationResult`, and token splitting functionality

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-02T18:15:31Z

+      throw new Exception(String.format("Failed to submit nametag transfer commitment: %s",
+          nametagMintResponse.getStatus()));


The error message references nametagMintResponse.getStatus() but should reference nametagSecondUseResponse.getStatus() since this is handling the failure of the second use nametag transfer, not the mint response.

Suggested change

throw new Exception(String.format("Failed to submit nametag transfer commitment: %s",

nametagMintResponse.getStatus()));

nametagSecondUseResponse.getStatus()));

Copilot · 2025-09-02T18:15:31Z

+      if (status == InclusionProofVerificationStatus.PATH_NOT_INCLUDED) {
+        CompletableFuture.delayedExecutor(intervalMillis, TimeUnit.MILLISECONDS)
+            .execute(() -> checkInclusionProof(client, commitment, future, startTime, timeoutMillis,
+                intervalMillis));
+      } else {
+        future.completeExceptionally(
+            new RuntimeException(String.format("Inclusion proof verification failed: %s", status)));
+      }


Missing return statement after scheduling retry in the PATH_NOT_INCLUDED case. This will cause both the retry to be scheduled AND the exception to be thrown, leading to unexpected behavior.

Copilot · 2025-09-02T18:15:31Z

+
+      this.id = id;
+      this.type = type;
+      this.data = data == null ? null : Arrays.copyOf(data, data.length);


Potential NullPointerException when data is null. The condition checks if data is null but then calls Arrays.copyOf(data, data.length) which will throw NPE if data is null. Should be: this.data = data != null ? Arrays.copyOf(data, data.length) : null;

Suggested change

this.data = data == null ? null : Arrays.copyOf(data, data.length);

this.data = data != null ? Arrays.copyOf(data, data.length) : null;

MastaP · 2025-09-02T18:18:36Z

-        return aggregatorClient;
-    }
+    return this.client.submitCommitment(commitment.getRequestId(), commitment.getTransactionData()
+        .calculateHash(token.getId(), token.getType()), commitment.getAuthenticator());


to extend my previous comment: transfer could also have commitment.getTransactionData().calculateHash() with no arguments and inside calculateHash() there might be a lambda which has token id and type in its closure

MastaP · 2025-09-02T18:21:16Z

+
+    String[] result = address.split("://", 2);
+    if (result.length != 2) {
+      throw new IllegalArgumentException("Invalid address format");


include invalid input in the message, easier to read logs and figure out what went wrong

MastaP · 2025-09-02T18:37:25Z

+
+      this.id = id;
+      this.type = type;
+      this.data = data == null ? null : Arrays.copyOf(data, data.length);


MastaP · 2025-09-02T18:42:12Z

+    byte[] imprint = new byte[this.data.length + 2];
+    int algorithmValue = this.algorithm.getValue();
+    imprint[0] = (byte) ((algorithmValue & 0xFF00) >> 8);
+    imprint[1] = (byte) (algorithmValue & 0xFF);


could be moved to HashAlgorithm as e.g. getImprintPrefix

martti007 added 23 commits July 15, 2025 10:39

Update SMT

8dbaa48

Add serializers for json and cbor

9b66f67

Updated Inclusion proof and SMT code

9c0eb55

Add JsonRpcError serializer

7b8fdf0

Add all requests and appropriate serializers

3ef59bc

Add Token json serializer

24a5aac

Remove cbor encoder test

3f7e82b

Fix StateTransitionClient

e76f8af

Make nametag mint work

d5f8266

Fix JSON nametag parsing

4f054bd

Add tests for multiple time nametag usage

7cbe4c6

Update code style

fc4ed8a

Update tests

19e34fe

Change hashing exception to runtime exception

4a0c304

Move smt to mtree package

09ffb63

Update Sum tree hashing

1441ae2

Make path branch sibling and branch getters return optional

8115b75

Make nullable field get data optional

a75351e

Add checkstyle, update libraries and naming for sum tree classes

e89ad02

Almost finished token split, removed createTransaction from client

e93d626

Update split token, add test

51571b1

Add note for serialization

055352f

Update checkstyle, fix errors for java

672b562

MastaP reviewed Aug 22, 2025

View reviewed changes

martti007 added 3 commits August 26, 2025 17:27

Fix serialization between js and java sdk

3b545e2

Update SMT path, mint reason verification and overall serialization

e89f18d

Fix doc, code style and errors

19f0efd

MastaP requested a review from Copilot September 2, 2025 18:14

Copilot AI reviewed Sep 2, 2025

View reviewed changes

MastaP reviewed Sep 3, 2025

View reviewed changes

Fix some checkstyle errors

6c58a52

MastaP changed the title ~~DRAFT: Code updates for latest changes~~ Code updates for latest changes Sep 5, 2025

MastaP approved these changes Sep 5, 2025

View reviewed changes

MastaP merged commit c74798e into main Sep 5, 2025
2 checks passed

MastaP deleted the code-update branch September 5, 2025 07:23

This was linked to issues Sep 6, 2025

Add nametags #2

Closed

Token splits #1

Closed

		throw new Exception(String.format("Failed to submit nametag transfer commitment: %s",
		nametagMintResponse.getStatus()));

	throw new Exception(String.format("Failed to submit nametag transfer commitment: %s",
	nametagMintResponse.getStatus()));
	nametagSecondUseResponse.getStatus()));

	this.data = data == null ? null : Arrays.copyOf(data, data.length);
	this.data = data != null ? Arrays.copyOf(data, data.length) : null;

Uh oh!

Conversation

martti007 commented Aug 19, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants