Add serializers, unify flow for transactions

[martti007]

No description provided.

[Copilot]

Pull Request Overview

This PR replaces inline serialization methods with dedicated JSON/CBOR serializers for transactions, commitments, and tokens, and updates the client and tests to use a unified commitment workflow.

• Introduce TransactionJsonSerializer, TransactionDataJsonSerializer, CommitmentJsonSerializer, TokenJsonSerializer, and their CBOR counterparts
• Remove old toJSON/toCBOR methods and deserializer classes; update StateTransitionClient to use a new submitCommitment API
• Update tests to use new serializers and assert on SubmitCommitmentStatus

Reviewed Changes

Copilot reviewed 36 out of 36 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tests/token/CommonTestFlow.ts	Swap out old offline client flow for new Commitment and serializers
tests/MintTokenUtils.ts	Change submitTransaction to Commitment.create + submitCommitment
src/transaction/TransactionData.ts	Remove embedded JSON/CBOR methods; expose getters; update toString
src/transaction/Transaction.ts	Drop inline serialization; rely on external serializers
src/transaction/Commitment.ts	Add Commitment.create factory and import SigningService
src/token/TokenFactory.ts	Switch from ITokenDeserializer to ITokenSerializer
src/token/Token.ts	Delegate .toJSON/.toCBOR to TokenJsonSerializer/TokenCborSerializer
src/serializer/json/...	Add JSON serializers for transactions, commitments, and tokens
src/serializer/cbor/...	Add CBOR serializers for transactions, commitments, and tokens
src/StateTransitionClient.ts	Replace old submitTransaction with submitCommitment workflows
src/OfflineStateTransitionClient.ts	Remove; offline flow moved into tests and new serializers

Comments suppressed due to low confidence (4)

src/token/TokenFactory.ts:12

• [nitpick] The constructor parameter is named deserializer but implements ITokenSerializer (which actually performs deserialization). Consider renaming it to tokenSerializer or renaming the interface to ITokenDeserializer to avoid confusion.

import { PredicateType } from '../predicate/PredicateType.js';

src/serializer/token/ITokenSerializer.ts:9

• [nitpick] This interface is named ITokenSerializer but defines a deserialize method. Renaming it to ITokenDeserializer would better reflect its responsibility and improve API clarity.

export interface ITokenSerializer {

src/transaction/TransactionData.ts:19

• [nitpick] The JSDoc parameter uses _salt, which matches the private field but is unusual in public docs. You may want to reference salt in docs and describe that it maps to the private _salt field for consistency.

   * @param _salt             Salt for current transaction

src/serializer/json/transaction/TransactionJsonSerializer.ts:33

• Consider adding unit tests for TransactionJsonSerializer.serialize and deserialize to verify that the round-trip between object and JSON works correctly.

  public static serialize(transaction: Transaction<TransactionData>): ITransactionJson<ITransactionDataJson> {

[MastaP]

@martti007 need to keep Readme in sync