CLDR-14218 update tooling & fix for tests. #1479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
#666 obviated? |
srl295
previously approved these changes
Aug 31, 2021
| } | ||
|
|
||
| static final Set<String> ISOLATES = ImmutableSet.of("ko", "qu", "root"); | ||
| static final Set<String> ISOLATES = ImmutableSet.of("ko", "qu", "root", "ce", "kgp", "und"); |
Member
There was a problem hiding this comment.
I wondered if und belonged here.
Member
Author
There was a problem hiding this comment.
Yes, it's needed here (edge case)
srl295
changed the title
Member
|
commit message starts with (I fixed the PR title already)
needs to be CLDR-14218 |
macchiati
force-pushed
the
CLDR-14218-fix-language-containment
branch
from
afff46a to
d130f57
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
DavidLRowe
approved these changes
Aug 31, 2021
Contributor
DavidLRowe
left a comment
DavidLRowe
left a comment
There was a problem hiding this comment.
I have no clue on most of these items! I spot-checked the few I do understand and don't find anything to change. So here's my approval for what it's worth!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-14218
Imported the wikidata for language groups.
Modified the tool and test to fix the errors
Didn't yet fix the cycles, but those are minor.
Added some more information about how to fix any problems that arise.
This PR completes the ticket.