-
Notifications
You must be signed in to change notification settings - Fork 422
CLDR-17223 Add nestedBracketReplacement for use in display names #5240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Do I need to add this to any of the following files where I find moreInformation referenced:
Also, about this test failure: I want this to not appear in survey tool, because it's easy to get wrong and it hardly ever changes. How should I do this? Should I add it to |
|
I was worried about not every language using parentheses (thereby a substitution could fail) but parentheses are pretty universal for Can you test out the algorithm that would implement this on RTL locales? I want to make sure it doesn't cause problems. Naming-wise, I like "innerBracket" (a bracket that is in a bracket) over "nestedBracketReplacement", but I defer to you. Per usual, that's my 2 cents but I am happy to follow your lead. I'm deferring the accept to someone who is a more frequent Design group member. |
|
The stuff to update is in https://cldr.unicode.org/development/updating-dtds. The way to hide stuff in the survey tool is not obvious. It is to use a Example: I'll file a ticket to fix that. |
macchiati
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ticket has been accepted, so this is not blocked by that.
I have one open question; otherwise this looks good.
|
|
||
| <!-- Moved up as part of change to moderate --> | ||
| <coverageLevel value="moderate" match="characters/ellipsis[@type='%ellipsisTypes']"/> | ||
| <coverageLevel value="moderate" match="characters/nestedBracketReplacement"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think coverage might need to be complete, that is, have the source attribute. But the value can be '%A'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(this comment is on an old version of the PR before I figured out how to do it)
| | hi-u-nu-latn-t-en-h0-hybrid | Hindi (Hybrid: English, Western Digits) | | ||
| | en-u-nu-deva-t-de | English (Transform: German, Devanagari Digits) | | ||
| | fr-z-zz-zzz-v-vv-vvv-u-uu-uuu-t-ru-Cyrl-s-ss-sss-a-aa-aaa-x-u-x | French (Transform: Russian \[Cyrillic\], uu: uuu, a: aa-aaa, s: ss-sss, v: vv-vvv, x: u-x, z: zz-zzz) | | ||
| | hi-u-nu-latn-t-en-h0-hybrid | Hindi (Western Digits, Hybrid: English) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. The question I have is, when there are both T and U, which is "most important" for the user. Example, I think that for hi-Latn, the fact that it is a hybrid might be more important.
Also need to check; I think we might have a specialized name for hi-Latin, namely Hinglish
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the order in order to make it more clear that the Unicode extension keywords apply to the main language and not the transform language. Example:
my-IN-t-en-MM-u-nu-latn |
|
|---|---|
| Current Spec | Burmese (India, Transform: English [Myanmar [Burma]], Latin Digits) |
| Flatten, current order | Burmese (India, Transform: English, Myanmar [Burma], Latin Digits) |
| Flatten, new order | Burmese (India, Latin Digits, Transform: English, Myanmar [Burma]) |
With "Flatten, current order", it's not clear that "Latin Digits" applies to "Burmese (India)" and not "English (Myanmar [Burma])"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, makes sense
I don't see how this would adversely impact RTL locales relative to not performing the replacement. We're swapping one bracket for another, with the same bidi classes.
Were you thinking something like: <innerBracket bracket="(">[</innerBracket>I feel very neutral on the name of the XML tag. |
09c4419 to
5bf384b
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
|
@conradarcturus did you wish to reply to my reply above, or shall I merge this? |

CLDR-17223
NOTE: The CLDR implementation of locale display names needs to be updated with the new algorithm.
ALLOW_MANY_COMMITS=true