-
Notifications
You must be signed in to change notification settings - Fork 422
CLDR-19203 Update currencies: BGN to EUR #5289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I followed instructions at I downloaded the updated versions of the two XML files. I ran the tool as follows: There was no exception. Per instructions, "If any country changes the use of a currency, verify that there is a corresponding entry in SupplementalData"; common/supplemental/supplementalData.xml already includes: Evidently it was already revised for the change from BGN to EUR. common/bcp47/currency.xml still has I don't see any indication that the en.xml shouldn't need any change -- it already has EUR and BGN. https://cldr.unicode.org/development/updating-codes/update-currency-codes refers to a file whose location has moved: (old:) tools/java/org/unicode/cldr/util/data/ISO4217.txt I will fix that in a second commit. |
-Revise update-currency-codes.md to show current location of ISO4217.txt -Other changes to update-currency-codes.md were made automatically by VS Code editor
macchiati
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great
srl295
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a logknownissue to remove also? @pedberg-icu
@srl295 @btangmu Yes, see the now-related CLDR-19177 and the logKnownIssue against it in Also aren't there some ISO4217.txt and iso4217raw.txt files that need updating, in |
Yes those should update too |
Thanks! OK, I've removed the check mark from "This PR completes the ticket" and I will merge this and follow up with another PR. It looks like the remaining changes will be in different files. |
Update 2 XML files and one markdown file
CLDR-19203
This PR completes the ticket.
ALLOW_MANY_COMMITS=true