Skip to content

CLDR-14218 CLDR 38 BRS A14.1 #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Aug 25, 2020

CLDR-14218 ( was CLDR-14116 ) A14.1 (#664 is A14, UN codes)

@srl295
Copy link
Member Author

srl295 commented Aug 25, 2020

@macchiati ^ WIP (still need to review languageGroup.xml) but needed to make these changes in order to get it to run

@srl295 srl295 changed the title Containment a14 1 14116bis CLDR-14116 CLDR 38 BRS A14.1 Aug 25, 2020
macchiati
macchiati previously approved these changes Aug 25, 2020
Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srl295
Copy link
Member Author

srl295 commented Aug 25, 2020

@macchiati do some of these BRS steps depend on each other? I. E. Do I need to regenerate this now that the UN codes are merged?

@macchiati
Copy link
Member

All the code updates are pretty independent. After we get done with them, some of the further processing needs them all to be done. But this one is fine.

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • common/supplemental/languageGroup.xml is now changed in the branch
  • tools/cldr-unittest/src/org/unicode/cldr/unittest/TestAll.java is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295
Copy link
Member Author

srl295 commented Aug 25, 2020

Like to get #666 passing before proceeding on this.

@srl295 srl295 changed the title CLDR-14116 CLDR 38 BRS A14.1 CLDR-14218 CLDR 38 BRS A14.1 Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants