Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds periodic “vitals” (memory, disk, CPU load) reporting to the end-to-end generateDataAndRun.sh script output to help monitor resource usage during long runs.
Changes:
- Start a background loop that prints memory/disk/load stats every 30 seconds.
- Stop the background monitor near the end of the script.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Push testresults and test reports to Cloud Storge | ||
| # TODO | ||
| echo "End-to-end script finished successfully" | ||
| kill $MONITOR_PID |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a background monitoring loop to generateDataAndRun.sh for logging system vitals during execution. The review suggests using a trap to ensure the monitor process is cleaned up if the script fails and removing the now-redundant explicit kill command.
| # Push testresults and test reports to Cloud Storge | ||
| # TODO | ||
| echo "End-to-end script finished successfully" | ||
| kill $MONITOR_PID |
There was a problem hiding this comment.
If a trap is implemented to handle the cleanup of the background monitor process, this explicit kill command becomes redundant and can be removed to avoid potential 'No such process' errors during exit.
|
And now CI passes again. |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
No description provided.