Skip to content

ICU-23447 MessageFormat ICU4C: Make Function* pointers const - #4072

Open
catamorphism wants to merge 4 commits into
unicode-org:mainfrom
catamorphism:function-const
Open

ICU-23447 MessageFormat ICU4C: Make Function* pointers const#4072
catamorphism wants to merge 4 commits into
unicode-org:mainfrom
catamorphism:function-const

Conversation

@catamorphism

@catamorphism catamorphism commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Change MFFunctionRegistry::getFunction() to return const Function* instead of Function*, with Function::call() becoming const.

Checklist

  • Required: Issue filed: ICU-23447
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-NNNNN Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-NNNNN Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable
  • Approver: Feel free to merge on my behalf

ALLOW_MANY_COMMITS=true

@catamorphism
catamorphism requested a review from srl295 July 9, 2026 00:08
@CLAassistant

CLAassistant commented Jul 9, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@jira-pull-request-webhook

Copy link
Copy Markdown

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

Change MFFunctionRegistry::getFunction() to return const Function* instead
of Function*, with Function::call() becoming const.
@jira-pull-request-webhook

Copy link
Copy Markdown

Notice: the branch changed across the force-push!

  • icu4c/source/i18n/unicode/messageformat2_function_registry.h is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

srl295
srl295 previously approved these changes Aug 20, 2026
Comment thread icu4c/source/test/intltest/messageformat2test.h
srl295
srl295 previously approved these changes Aug 20, 2026
@srl295

srl295 commented Aug 20, 2026

Copy link
Copy Markdown
Member

Need approval of my additional commits:

I can't squash because i'm not @catamorphism but would like to merge this so it can be the basis of the updated MF2 C++ API proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants