ICU-23248 Generate more modern javadoc for site - #4130
Open
mihnita wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Note: the 4 warnings in the [action run] "Annotations" are bogus. They are caused by javadoc running on See it here: https://mihai-nita.net/tmp/javadoc26/com/ibm/icu/util/ULocale.html See it here: https://mihai-nita.net/tmp/javadoc26/com/ibm/icu/text/UnicodeFilter.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was discussed by email in the ICU team ("Updating javadoc look and feel?", May 15).
It generates a more modern javadoc:
Compare MessageFormat current vs MessageFormat new
I tested the changes by running the action in my repo.
See the result of the run here: https://github.com/mihnita/icu/actions/runs/32469385369
The artifacts (
icu4j-binariesandicu4j-fulljavadoc) are at the bottom of the action.They are also uploaded in the (fake) release in my repo: https://github.com/mihnita/icu/releases/tag/release-79.1
Then I downloaded the artifacts attached to the action and diff-ed them against the ones in the release (identical).
Finally, I extracted the
icu4j-79.0.1-fulljavadoc.jarand posted it to my web site: https://mihai-nita.net/tmp/javadoc26/Then I navigated it randomly, did some searches, etc. All good, from all I can see.
Checklist