Skip to content

Improve ergonomics of icu4x-datagen #6476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 21, 2025
Merged

Improve ergonomics of icu4x-datagen #6476

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5452c83
Add rayon feature to icu4x-datagen
sffc Apr 21, 2025
98a0673
Improve no-networking error messages in icu4x-datagen
sffc Apr 21, 2025
8adfdfd
Add tip for running icu4x-datagen to CONTRIBUTING.md
sffc Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions provider/icu4x-datagen/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ version.workspace = true
[dependencies]
icu_provider = { workspace = true }
icu = { workspace = true, features = ["datagen"] }
icu_provider_export = { workspace = true, features = ["rayon"] }
icu_provider_export = { workspace = true }
icu_provider_source = { workspace = true, optional = true }
icu_provider_registry = { workspace = true }

Expand All @@ -31,7 +31,7 @@ log = { workspace = true }
simple_logger = { workspace = true }

[features]
default = ["use_wasm", "networking", "fs_exporter", "blob_exporter", "baked_exporter", "provider"]
default = ["use_wasm", "networking", "fs_exporter", "blob_exporter", "baked_exporter", "provider", "rayon"]
provider = ["dep:icu_provider_source"]
baked_exporter = ["icu_provider_export/baked_exporter"]
blob_exporter = ["icu_provider_export/blob_exporter"]
Expand All @@ -46,6 +46,7 @@ use_wasm = ["icu_provider_source?/use_wasm"]
use_icu4c = ["icu_provider_source?/use_icu4c"]
networking = ["icu_provider_source?/networking"]
experimental = ["icu_provider_source?/experimental", "icu/experimental"]
rayon = ["icu_provider_export/rayon"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: parallelism? rayon is also fine, it's widely understood in rust

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature was already called rayon 🤷‍♂️

#6482


[package.metadata.cargo-all-features]
# We don't need working CPT builders for check
Expand Down