Skip to content

Conversation

@sffc
Copy link
Member

@sffc sffc commented May 1, 2025

@gemini-code-assist You should have noticed this earlier.

Follow-up to #6515

@sffc sffc requested a review from Manishearth as a code owner May 1, 2025 22:30
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @sffc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request addresses a typo in the documentation across multiple files. Specifically, it corrects instances where ZonedDateTime was incorrectly used instead of ZonedIsoDateTime. The change affects C++, Dart, JavaScript, and Rust bindings, ensuring consistency in the documentation for the from_epoch_milliseconds_and_utc_offset constructor.

Highlights

  • Documentation Fix: Corrects a typo in the documentation, replacing ZonedDateTime with ZonedIsoDateTime.
  • Cross-Language Consistency: Ensures consistent documentation across C++, Dart, JavaScript, and Rust bindings.

Changelog

  • ffi/capi/bindings/cpp/icu4x/ZonedIsoDateTime.d.hpp
    • Replaced ZonedDateTime with ZonedIsoDateTime in the documentation for the from_epoch_milliseconds_and_utc_offset constructor (line 63 and 65).
  • ffi/capi/bindings/dart/ZonedIsoDateTime.g.dart
    • Replaced ZonedDateTime with ZonedIsoDateTime in the documentation for the from_epoch_milliseconds_and_utc_offset constructor (line 54 and 56).
  • ffi/capi/bindings/js/ZonedIsoDateTime.d.ts
    • Replaced ZonedDateTime with ZonedIsoDateTime in the documentation for the from_epoch_milliseconds_and_utc_offset constructor (line 36 and 38).
  • ffi/capi/bindings/js/ZonedIsoDateTime.mjs
    • Replaced ZonedDateTime with ZonedIsoDateTime in the documentation for the from_epoch_milliseconds_and_utc_offset constructor (line 152 and 154).
  • ffi/capi/src/zoned_datetime.rs
    • Replaced ZonedDateTime with ZonedIsoDateTime in the documentation for the from_epoch_milliseconds_and_utc_offset constructor (line 53 and 55).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


A typo's sneaky guise,
Misleading eyes, a false surprise.
Docs now aligned.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request aims to correct a typo in the documentation of the ZonedIsoDateTime class across multiple languages. The change replaces instances of ZonedDateTime with ZonedIsoDateTime in the comments, ensuring the documentation accurately reflects the class name.

Summary of Findings

  • Documentation Inconsistency: The documentation incorrectly referred to ZonedDateTime instead of ZonedIsoDateTime. This PR corrects the inconsistency.

Merge Readiness

The pull request corrects a documentation error and improves code clarity. I recommend merging it after addressing the review comments. I am unable to approve this pull request, and users should have others review and approve this code before merging.

@sffc sffc merged commit 5cfff24 into unicode-org:main May 1, 2025
29 checks passed
@sffc sffc deleted the ZonedIsoDateTime branch May 1, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants