Set ZoneNameTimestamp in FFI ZonedDateFormatter, ZonedTimeFormatter, and TimeZoneFormatter

[sffc]

Follow-up to #6517, #6378

Depends on #6528

[gemini-code-assist]

Hello @sffc, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request, a follow-up to #6517 and #6378, addresses the setting of ZoneNameTimestamp in the FFI for ZonedDateFormatter, ZonedTimeFormatter, and TimeZoneFormatter. The changes ensure that when a zone_name_timestamp is not explicitly provided, a default value is set. For formatters that include a date, the timestamp is set to noon on that date. Otherwise, it's set to a far-in-future timestamp.

Highlights

• Default ZoneNameTimestamp: The pull request sets a default ZoneNameTimestamp when one is not provided explicitly.
• Date-Specific Timestamp: For formatters with date information, the default timestamp is set to noon on the given date.
• Far-Future Timestamp: For formatters without date information, the default timestamp is set to a far-in-future value.

Changelog

Click here to see the changelog

• ffi/capi/src/timezone_formatter.rs
  • When zone_name_timestamp is not provided, sets it to icu_time::zone::ZoneNameTimestamp::far_in_future().
• ffi/capi/src/zoned_date_formatter.rs
  • When zone_name_timestamp is not provided, sets it to noon on the given date using icu_time::zone::ZoneNameTimestamp::from_date_time_iso().
  • Adds a clippy::unwrap_used allow attribute with a TODO to use Time::middle_of_day().
• ffi/capi/src/zoned_time_formatter.rs
  • When zone_name_timestamp is not provided, sets it to icu_time::zone::ZoneNameTimestamp::far_in_future().
• tools/make/codegen/templates/zoned_formatter.rs.jinja
  • Adds logic to set zone_name_timestamp based on whether the formatter flavor has a date.
  • If the flavor has a date, sets the timestamp to noon on that date.
  • If the flavor does not have a date, sets the timestamp to icu_time::zone::ZoneNameTimestamp::far_in_future().

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

The timestamp's call,
Future's echo, noon's embrace,
Zones find their own time.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request introduces a change to set the ZoneNameTimestamp in FFI for ZonedDateFormatter, ZonedTimeFormatter, and TimeZoneFormatter. This ensures that the time zone name is correctly resolved even when the zone_name_timestamp is not explicitly provided. The changes look good overall.

Merge Readiness

The pull request appears to be well-implemented and addresses the intended functionality. I am unable to directly approve this pull request, and recommend that others review and approve this code before merging. There are no critical or high severity issues, so the pull request is ready to be merged.

[sffc]

Thought: After this merges, the corresponding variant in DateTimeWriteError will be unreachable

[dpulls]

🎉 All dependencies have been resolved !