Skip to content

Add Dart PR health workflow #6803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add Dart PR health workflow #6803

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7498ac8
Add health wf
mosuem Aug 5, 2025
bafee80
Integrate into Build and Test
mosuem Aug 5, 2025
fc7716d
delete
robertbastian Aug 5, 2025
9003d8e
fail on checks
mosuem Aug 6, 2025
d43d30c
separate step
mosuem Aug 6, 2025
681fc2b
remove on
mosuem Aug 6, 2025
15b4a17
delete old
mosuem Aug 6, 2025
d3689f2
remove on
mosuem Aug 6, 2025
685f400
warn on
mosuem Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/workflows/health.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
name: Health
on:
pull_request:
branches: [ main ]
types: [opened, synchronize, reopened, labeled, unlabeled]

jobs:
health:
uses: dart-lang/ecosystem/.github/workflows/health.yaml@main
with:
checks: changelog,coverage,breaking,do-not-submit,leaking
coverage_web: true
sdk: 3.9.0-138.0.dev
permissions:
pull-requests: write
16 changes: 16 additions & 0 deletions .github/workflows/post_summaries.yaml
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really need this? we don't currently use any actions that post to PRs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a Github restriction, see https://securitylab.github.com/resources/github-actions-preventing-pwn-requests/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean do we really want to post summaries

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github doesn't allow for warnings, only failures or successes. In the case we don't want to post to PR comments, I would suggest to turn all warnings into failures. This then requires to add labels to skip checks if one wants to ignore the warning.

Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
name: Comment on the pull request

on:
# Trigger this workflow after the Health workflow completes. This workflow will have permissions to
# do things like create comments on the PR, even if the original workflow couldn't.
workflow_run:
workflows:
- Health
types:
- completed

jobs:
upload:
uses: dart-lang/ecosystem/.github/workflows/post_summaries.yaml@main
permissions:
pull-requests: write
Loading