Update UAX#29 text segmenter data rules to Unicode 17. #7128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makotokato
requested review from
a team,
Manishearth,
aethanyc,
robertbastian and
sffc
as code owners
sffc
previously approved these changes
Oct 20, 2025
There was a problem hiding this comment.
Seems fine, CC @Manishearth or @robertbastian to double check the Unicode property version workaround; I thought we had Unicode 17 on main
|
is there an issue for Unicode 17 segmenter? |
We have Unicode 17 properties, not Unicode 17 segmentation for line, iirc. |
Manishearth
previously approved these changes
Oct 20, 2025
robertbastian
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line segmenter is still old rules, so we need a hack for compatible with old ExtPic vs new ExtPic.