Build CodePointTries in datagen #7299
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
force-pushed
the
build-cpt
branch
3 times, most recently
from
5bc55ee to
82918ac
Compare
robertbastian
force-pushed
the
build-cpt
branch
from
82918ac to
c7289f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we use pre-built CPTs exported from ICU4C. ICU4C also exports the raw data, so we should build the tries ourselves. This is a step towards reading the UCD directly #4602.
However, the
icu_codepointtrie_builderWASM backend seems to not be able to handle this. Datagen times out after 6 hours 🤷