Dense zero trie Out of Range handling #7303 #7305
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… row values to go in dense matrix
… row values to go in dense matrix
|
|
sffc
reviewed
Dec 11, 2025
utils/zerotrie/tests/dense_test.rs
Outdated
| let dense_size = check_encoding(trie); | ||
| let simple_size = make_simple_ascii_trie(&data).byte_len(); | ||
|
|
||
| println!("Dense size: {}, Simple size: {}", dense_size, simple_size); |
Member
There was a problem hiding this comment.
Please add assertions on the two sizes. We assert the sizes because they should be stable, and because you can see what they are from reading the code. They should only change if we change the data structure or builder algorithm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on #7303.
When creating a dense sparse zerotrie, if the incoming values are too spread out for a dense matrix:
Also, added a test case for this. I am not certain that this test case is sufficient, this is my first contribution here.