Add full support for r datetime symbol
#7327
Conversation
robertbastian
requested review from
Manishearth,
sffc and
zbraniecki
as code owners
robertbastian
force-pushed
the
related
branch
from
c0cea90 to
e6b97e4
Compare
| /// | ||
| /// Lunar calendars, like [`Hijri`](crate::cal::Hijri), drift quickly through the Gregorian year, so related Gregorian | ||
| /// years are frequently repeated. | ||
| pub fn related_gregorian(self) -> i32 { |
There was a problem hiding this comment.
given that it's allowed to be negative (no eras), this should be ISO year, yes? or gregorian extended year.
I agree that hte "ISO calendar" isn't the most consistent concept, but "ISO year" is much more well defined
There was a problem hiding this comment.
CLDR calls it "related Gregorian" year
ISO is a format, Gregorian is a calendar. I will die on this hill
There was a problem hiding this comment.
If that's what CLDR calls it fair enough.
There was a problem hiding this comment.
Gregorian does not have signed years.
It has extended years; you could call it related_extended_gregorian but I don't think anyone wants that.
Plus, we already call it related_iso for cyclic years. You're the king of consistency.
There was a problem hiding this comment.
I'm happy to deprecate any mentions of related_iso
There was a problem hiding this comment.
ISO is a format
ISO-8601 defines a calendar system, not just a format.
There was a problem hiding this comment.
it defines a string format for the proleptic Gregorian calendar
sffc
left a comment
sffc
left a comment
There was a problem hiding this comment.
It's in CLDR, but it seems to have footguns. We shouldn't add new things that have known footguns.
| } | ||
| } | ||
|
|
||
| /// The Gregorian year in which this year started. |
There was a problem hiding this comment.
Observation: This produces surprising results for calendars with new years in the second half of the year, like Hebrew, Ethiopian, Coptic. It also means that multiple Hijri years will have the same related ISO year.
sffc
left a comment
sffc
left a comment
There was a problem hiding this comment.
We've been consistent about Gregorian meaning the calendar with eras and nonzero year numbers. Let's not muck it up
what's the footgun?
|
That there isn't a 1-to-1 mapping.
I prefer Temporal uses ISO for this. It's literally encoded into the API: |
The |
I consider ECMA's and Temporal's distinction between ISO and Gregorian a major flaw. I'd also like to point out that |
|
There were lengthy discussions in Temporal where we arrived at these designs, weighing lots and lots of tradeoffs. I could write it up but I have better things to spend my time on today. |
|
I don't really care about the name here. Self-consistency is a good motivator. I'd like to avoid deprecating things further just for naming reasons. |
3 participants
Currently we only support the
rsymbol for cyclic calendars, however nothing in the LDML says that it is only usable with cyclic calendars. This adds support for all other calendars.