Skip to content

Conversation

@robertbastian
Copy link
Member

Per LDML:

If the calendar does not provide cyclic year name data, or if the year value to be formatted is out of the range of years for which cyclic name data is provided, then numeric formatting is used (behaves like 'y').

Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meh, it's in LDML, but seems like a footgun. Returning an error if U is used in a non-cyclic calendar seems better, to inform clients that they should be using y. Let's please discuss with CLDR first.

@robertbastian
Copy link
Member Author

robertbastian commented Dec 18, 2025

We can also return an error and format y. You already do that in other error cases.

@robertbastian robertbastian requested a review from sffc December 18, 2025 23:01
@sffc
Copy link
Member

sffc commented Dec 18, 2025

We can also return an error and format y. You already do that in other error cases.

I'd approve if you did this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants