Skip to content

Cite Reingold and Shaukat in the AstronomicalSimulation docs #7332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sffc merged 1 commit into from
Dec 19, 2025
+4 −1
Merged

Cite Reingold and Shaukat in the AstronomicalSimulation docs #7332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion components/calendar/src/cal/hijri.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,8 @@ pub trait Rules: Clone + Debug + crate::cal::scaffold::UnstableSealed {

/// [`Hijri`] [`Rules`] based on an astronomical simulation for a particular location.
///
/// These simulations are unofficial and are known to not necessarily match sightings
/// These simulations use methods published by E. M. Reingold, S. K. Shaukat, et al.[^1]
/// These methods are not officially recognized in any region and do not match sightings
/// on the ground. Unless you know otherwise for sure, instead of this variant, use
/// [`UmmAlQura`], which uses the results of KACST's Mecca-based calculations.
///
Expand All @@ -142,6 +143,8 @@ pub trait Rules: Clone + Debug + crate::cal::scaffold::UnstableSealed {
///
/// This corresponds to the `"islamic-rgsa"` [CLDR calendar](https://unicode.org/reports/tr35/#UnicodeCalendarIdentifier)
/// if constructed with [`Hijri::new_simulated_mecca()`].
///
/// [^1]: See [calendrical_calculations::islamic::observational_islamic_from_fixed]
#[derive(Copy, Clone, Debug, PartialEq, Eq)]
pub struct AstronomicalSimulation {
pub(crate) location: SimulatedLocation,
Expand Down