Untangle Japanese calendars #7334
Merged
+297
−211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
force-pushed
the
japanext4
branch
from
a79a472 to
bccd8b4
Compare
robertbastian
force-pushed
the
japanext4
branch
from
bccd8b4 to
7974903
Compare
sffc
approved these changes
Dec 19, 2025
Member
sffc
left a comment
sffc
left a comment
There was a problem hiding this comment.
Seems fine; would be nice to share a bit of code where the logic is the same, like the first 20 lines of the GregorianYears function impls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully uncontroversial parts of #7322 and #7323
This splits the implementation of
JapaneseandJapaneseExtendedso that the complexity ofJapaneseExtendeddoesn't contribute toJapanese's code size.The datagen part correctly implements the
inheritEraslogic, instead of hardcoding it for Japanese, as CLDR is considering changes to the model.