feat(currency): add regional, core, and complete data markers and update extraction logic #7418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… update extraction logic - Introduced new data markers for regional, core, and complete currency essentials. - Updated the `extract_currency_essentials` function to accommodate the new markers. - Enhanced the `CurrencyData` struct to include region-specific currency mappings. - Added a new module for sliced currency essentials to support different currency slicing strategies. - Improved comments and documentation for clarity on currency data structures.
- Updated `currencies` and `RegionCurrencyEntry` to use `CurrencyCodeStr` as a key for better deserialization. - Added `CurrencyCodeStr` type as a wrapper for 3-letter currency codes. - Enhanced comments for clarity on currency slicing strategies in `sliced_essentials.rs`. - Implemented new data providers for regional, core, and complete currency essentials, improving data extraction logic.
- Introduced new data files for currency essentials, including complete, core, and regional data in various languages. - Implemented data providers for these new currency essentials, enhancing the extraction logic for better regional support. - Updated existing modules to include the new currency data structures and ensure compatibility with the latest changes. - Improved documentation and comments for clarity on the new data structures and their usage.
…urrencies - Introduced new data markers for CurrencyExtendedDataRegionalV1, CurrencyExtendedDataCoreV1, and CurrencyExtendedDataCompleteV1. - Updated the currency provider module to include these new markers, enhancing the currency formatting capabilities. - Refactored the extended currency data structure to utilize a macro for cleaner marker definitions. - Ensured compatibility with existing currency essentials and improved documentation for clarity on the new data structures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change introduces explicit data markers for currency essentials(regional, core, and complete) and updates the extraction logic to correctly classify and process them.
Changes included:
issues: #7404