-
Notifications
You must be signed in to change notification settings - Fork 255
Organize neo datetime provider code #7429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
082f385 to
b5cfca4
Compare
sffc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't love the churn but ok
sffc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stuff in components/datetime/src/provider/semantic_skeletons.rs is not really about semantic skeleta. It's just a bunch of data marker attributes, for looking up names as well as patterns. I think the file is a misnomer.
Glue patterns definitely don't belong in a file named names.rs. It's about as far as you can get away from names in datetime.
b5cfca4 to
a244f24
Compare
|
Pure rebase over Rob's PR, no changes. @sffc The glue key is a minor thing that can be moved later, I did this to be consistent with the choice we made in provider/source. We could just have glue.rs in both, in provider/source the code was very closely related so it stayed together. Happy to rename semantic_skeleton.rs if you have a suggestion. Things can also be further organized. I have a preference for merging this as is since this splits the module. After a split like this, further renames are much easier to do. |
|
Needs another rebase. |
|
Done |
Fixes #5613
I used the same organization as in #7386:
namesandsemantic_skeleta. Glue patterns go innamesfor now, but they're easy to move.