Skip to content

Conversation

@Manishearth
Copy link
Member

Fixes #5613

I used the same organization as in #7386: names and semantic_skeleta. Glue patterns go in names for now, but they're easy to move.

@Manishearth Manishearth force-pushed the neo-provider-org branch 3 times, most recently from 082f385 to b5cfca4 Compare January 15, 2026 04:06
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't love the churn but ok

Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stuff in components/datetime/src/provider/semantic_skeletons.rs is not really about semantic skeleta. It's just a bunch of data marker attributes, for looking up names as well as patterns. I think the file is a misnomer.

Glue patterns definitely don't belong in a file named names.rs. It's about as far as you can get away from names in datetime.

@Manishearth
Copy link
Member Author

Pure rebase over Rob's PR, no changes.

@sffc The glue key is a minor thing that can be moved later, I did this to be consistent with the choice we made in provider/source. We could just have glue.rs in both, in provider/source the code was very closely related so it stayed together.

Happy to rename semantic_skeleton.rs if you have a suggestion. Things can also be further organized.

I have a preference for merging this as is since this splits the module. After a split like this, further renames are much easier to do.

@robertbastian robertbastian requested review from sffc and removed request for robertbastian January 15, 2026 15:42
@sffc
Copy link
Member

sffc commented Jan 17, 2026

Needs another rebase.

@Manishearth
Copy link
Member Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disentangle the neo datetime datagen

2 participants