issue(locale): fix locale grouping logic #7437
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adjusted various timezone data files to reflect updated sizes and identifiers, including `fingerprints.csv`, `timezone_names_cities_override_v1.rs.data`, and others. - Enhanced the `script_locale_group` function in `cldr_cache.rs` to include additional test cases for language script grouping, ensuring accurate mapping for languages like N'Ko and Bambara. - Removed redundant exemplar city entries in the `timezone_names_locations_root_v1.rs.data` file to streamline data structure.
younies
requested review from
a team,
Manishearth,
robertbastian and
sffc
as code owners
robertbastian
requested changes
Jan 16, 2026
Member
robertbastian
left a comment
robertbastian
left a comment
There was a problem hiding this comment.
what is the "fix" here? this PR increases data size
| timezone/names/cities/override/v1, <lookup>, 855B, 167 identifiers | ||
| timezone/names/cities/override/v1, <total>, 268467B, 261786B, 151 unique payloads | ||
| timezone/names/cities/override/v1, <lookup>, 871B, 169 identifiers | ||
| timezone/names/cities/override/v1, <total>, 283519B, 276751B, 153 unique payloads |
| timezone/names/generic/short/v1, zh-SG, -> ta-MY | ||
| timezone/names/locations/override/v1, <lookup>, 1114B, 222 identifiers | ||
| timezone/names/locations/override/v1, <total>, 1000284B, 971921B, 208 unique payloads | ||
| timezone/names/locations/override/v1, <total>, 1037724B, 1009365B, 208 unique payloads |
sffc
requested changes
Jan 16, 2026
Member
sffc
left a comment
sffc
left a comment
There was a problem hiding this comment.
This seems to impact mixed-script languages and causes fallback to occur across script boundaries, which I don't think is desirable. For example, with yue, currently we go
"yue" -> "yue-Hant-HK" -> "und-Hant" -> "zh-Hant-HK" -> "zh-Hant"
But now we go
"yue" -> "yue-Hant-HK" -> "und-Hant" -> "zh-Hant-HK" -> "zh"
which results in Simplified Chinese instead of Traditional Chinese going into the "und-Hant" data key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desription
script_locale_groupfunction incldr_cache.rsto include additional test cases for language script grouping, ensuring accurate mapping for languages like N'Ko and Bambara.fingerprints.csv,timezone_names_cities_override_v1.rs.data, and others.