Skip to content

added missing CLDR skeleton patterns #7515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
psg-19 wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

added missing CLDR skeleton patterns #7515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52bd75a
added missing CLDR skeleton patterns
psg-19 Jan 28, 2026
239e702
utilizing Hv/hv skeleton patterns
psg-19 Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions components/datetime/src/dynamic.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,6 +479,9 @@ impl_attrs! {
(ATTR_T, STR_T, "j"),
(ATTR_T12, STR_T12, "h"),
(ATTR_T24, STR_T24, "h0"),
(ATTR_TV, STR_TV, "jv"),
(ATTR_T12V, STR_T12V, "hv"),
(ATTR_T24V, STR_T24V, "h0v"),
]
}

Expand Down
Binary file modified components/datetime/tests/fixtures/tests/skeletons.bin
View file
Open in desktop
Binary file not shown.
11 changes: 11 additions & 0 deletions components/datetime/tests/fixtures/tests/skeletons.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,34 @@
{
"skeletons": [
"Gy",
"GyMd",
"GyMdE",
"GyMMMdE",
"y",
"yM",
"yMdE",
"yMdEEEE",
"yMdE",
"yMMM",
"yMMMdE",
"yw",
"M",
"Md",
"Mdd",
"MdE",
"MMd",
"MMdd",
"MMMdE",
"d",
"dE",
"Eh",
"h",
"hm",
"hms",
"hv",
"Hm",
"Hms",
"Hv",
"ms",
"mmss"
]
Expand Down
10 changes: 5 additions & 5 deletions provider/source/src/datetime/available_formats.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,15 +184,15 @@ mod test {

#[rustfmt::skip]
const SUPPORTED_STRING_SKELETONS: &[&str] = &[
"E", "dEEEE", "EHm", "EHms", "dE", "Ehm", "Ehms", "H", "HHmm", "HHmmss", "Hm", "Hms", "M",
"MdEEEE", "MdE", "MMM", "MMMdEEEE", "MMMdE", "MMMM",
"E", "dEEEE", "Ed", "Eh", "EHm", "EHms", "dE", "Ehm", "Ehms", "EH", "H", "HHmm", "HHmmss", "Hm", "Hms", "M",
"MdEEEE", "MdE", "MEd", "MMM", "MMMdEEEE", "MMMdE", "MMMEd", "MMMM",
"MMMMdEEEE", "MMMMdE", "MMMMd",
"MMMMdd", "MMMd", "MMMdd", "MMd", "MMdd", "Md", "Mdd", "d", "h", "hm", "hms", "mmss", "ms",
"y", "yM", "yMdEEEE", "yMdE", "yMM", "yMMM", "yMMMdEEEE", "yMMMdE", "yMMMM", "yMMMMdEEEE",
"y", "yM", "yMdEEEE", "yMdE", "yMEd", "yMM", "yMMM", "yMMMdEEEE", "yMMMdE", "yMMMEd", "yMMMM", "yMMMMdEEEE",
"yMMMMdE", "yMMMMdcccc", "yMMMMd", "yMMMd", "yMMdd", "yMd",
"Gy", "GyM", "GyMMM", "GyMMMdEEEE", "GyMMMdE", "GyMMMM", "GyMMMMdE", "GyMMMMd", "GyMMMd",
"Gy", "GyM", "GyMd", "GyMEd", "GyMMM", "GyMMMdEEEE", "GyMMMdE", "GyMMMEd", "GyMMMM", "GyMMMMdE", "GyMMMMd", "GyMMMd",
// Time zones
"HHmmZ", "Hmsv", "Hmsvvvv", "Hmv", "Hmvvvv", "hmsv", "hmsvvvv", "hmv", "hmvvvv",
"HHmmZ", "Hmsv", "Hmsvvvv", "Hmv", "Hmvvvv", "hmsv", "hmsvvvv", "hmv", "hmvvvv", "Hv", "hv",
];

// NOTE: If you are moving this to the SUPPORTED section, make sure to remove the match
Expand Down
5 changes: 5 additions & 0 deletions provider/source/src/datetime/semantic_skeletons.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,6 +479,11 @@ fn gen_time_components(
if check_for_field(attributes, "h0") {
filtered_components.hour_cycle = Some(HourCycle::H23);
}
// Select timezone if requested (for Hv/hv skeleton utilization)
if check_for_field(attributes, "v") {
filtered_components.time_zone_name =
Some(components::TimeZoneName::ShortGeneric);
}
filtered_components
}

Expand Down
Loading