Update comments that is Unicode 17.0 for UAX#29#7661
Open
makotokato wants to merge 3 commits intounicode-org:mainfrom
Open
Update comments that is Unicode 17.0 for UAX#29#7661makotokato wants to merge 3 commits intounicode-org:mainfrom
makotokato wants to merge 3 commits intounicode-org:mainfrom
Conversation
makotokato
requested review from
Manishearth,
robertbastian and
sffc
as code owners
Manishearth
approved these changes
Feb 18, 2026
Contributor
|
@makotokato Can we also add Unicode version to the top-level documentation for all the segmenter? Something like aethanyc@40aaa1e If you feel the commit is good, feel free to add it to this PR. |
sffc
approved these changes
Feb 18, 2026
Member
|
I'd prefer a human-readable version number in lib.rs, but a link to the specific spec version is an improvement over the status quo. |
robertbastian
added
the
waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7128 is updated to Unicode 17 for UAX#29, but I didn't update toml file's documents.