Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/decimal/src/provider.rs
Original file line number Diff line number Diff line change
Expand Up @@ -157,13 +157,13 @@ icu_provider::data_marker!(
);

icu_provider::data_marker!(
/// The digits for a given numbering system. This data ought to be stored in the `und` locale with an auxiliary key
/// The digits for a given numbering system. This data ought to be stored in the `und` locale with a marker attribute
/// set to the numbering system code.
DecimalDigitsV1,
"decimal/digits/v1",
[char; 10],
#[cfg(feature = "datagen")]
attributes_domain = "numbering_system"
attributes_domain = "numbering-system"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: why did you change the casing? And in make_testdata.rs, you use _. I wasn't sure whether we should use _ or - so I started using _ on my newly added attribute domains since it seems that what we are using elsewhere.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make_testdata was an oversight.

we use - in most ICU4X identifiers, I don't think we use _ anywhere. - is easier to type and more pleasing to read

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not just here, it is other places, too:

https://github.com/search?q=repo%3Aunicode-org%2Ficu4x%20attributes_domain&type=code

I don't want us to become inconsistent. I would rather make a separate PR to change all the instances at the same time, rather than switching just this one. (Please don't change all the others in this PR)

);

#[cfg(feature = "datagen")]
Expand Down
2 changes: 2 additions & 0 deletions components/experimental/src/transliterate/provider.rs
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ icu_provider::data_marker!(
RuleBasedTransliterator<'static>,
#[cfg(feature = "datagen")]
expose_baked_consts = true,
#[cfg(feature = "datagen")]
attributes_domain = "transliterator",
);

/// The data struct representing [UTS #35 transform rules](https://unicode.org/reports/tr35/tr35-general.html#Transforms).
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading