-
Notifications
You must be signed in to change notification settings - Fork 264
Add more collator data and filtering to testdata; add transliterator attributes domain #7679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: why did you change the casing? And in make_testdata.rs, you use
_. I wasn't sure whether we should use_or-so I started using_on my newly added attribute domains since it seems that what we are using elsewhere.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make_testdata was an oversight.
we use
-in most ICU4X identifiers, I don't think we use_anywhere.-is easier to type and more pleasing to readThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not just here, it is other places, too:
https://github.com/search?q=repo%3Aunicode-org%2Ficu4x%20attributes_domain&type=code
I don't want us to become inconsistent. I would rather make a separate PR to change all the instances at the same time, rather than switching just this one. (Please don't change all the others in this PR)