Skip to content

Matched version number to Unicode 17, and removed U+2612 after discus… - #1504

Open
jowilco wants to merge 1 commit into
unicode-org:mainfrom
jowilco:jowilco/mathclass_version_match
Open

Matched version number to Unicode 17, and removed U+2612 after discus…#1504
jowilco wants to merge 1 commit into
unicode-org:mainfrom
jowilco:jowilco/mathclass_version_match

Conversation

@jowilco

@jowilco jowilco commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

…sion with David

TODO: Please describe your changes here.

  • Approver: Feel free to merge on my behalf
    • rebase & merge one or more commits
    • squash & merge multiple commits into one

@jowilco
jowilco requested a review from asmusf August 17, 2026 22:28

@davidcarlisle davidcarlisle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming that this does as advertised (renames to 17 and drops U+2612).

The alternative of adding U+2610 and U+2611 to match U+2612 was also discussed in email, I have a mild preference for the version here, dropping all three, but don't mind either way.

Approving but I'll leave the merge to @asmusf

@eggrobin

Copy link
Copy Markdown
Member

This should probably be on top of a rename of revision-16 to revision-17 then.

@eggrobin

Copy link
Copy Markdown
Member

Also, this needs updating to match:

// UTR #25 is not synchronized, but its releases correspond to the preceding
// version of Unicode (or, in the case of revision 12, to the following
// day’s version of Unicode).
private static String getMathRevision(VersionInfo versionInfo) {
VersionInfo[] mathToSubsequentUnicodeVersion = {
/* 0 ∄ */ null,
/* 1 (Proposed Draft) */ null,
/* 2 (Proposed Draft) */ null,
/* 3 (Proposed Draft) */ null,
/* 4 (Proposed Draft) */ null,
/* 5 (Draft) */ null,
/* 6, 2003-08-31 */ VersionInfo.UNICODE_4_0, // First printing, August 2003
/* 7 (Proposed Update) */ null,
/* 8 (Proposed Update) */ null,
/* 9, 2007-05-07 */ VersionInfo.UNICODE_5_0, // 2006 July 14
/* 10 (Proposed Update) */ null,
/* 11, 2008-08-14 */ VersionInfo.UNICODE_5_1, // 2008 April 4
/* 12, 2010-10-10 */ VersionInfo.UNICODE_6_0, // 2010 October 11
/* 13, 2012-04-02 */ VersionInfo.UNICODE_6_1, // 2012 January 31
/* 14, 2015-07-31 */ VersionInfo.UNICODE_7_0, // 2014 June 16
/* 15, 2017-05-30 */ VersionInfo.UNICODE_9_0, // 2016 June 21
/* 16, WIP */ UTR25_REVISION_16,
};
String result = null;
for (int i = 0; i < mathToSubsequentUnicodeVersion.length; ++i) {
if (mathToSubsequentUnicodeVersion[i] != null
&& mathToSubsequentUnicodeVersion[i].compareTo(versionInfo) <= 0) {
result = Integer.toString(i);
}
}
return result;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants