Add formatting response to ULSP#517
Merged
Jafaral merged 2 commits intouniconproject:masterfrom Jun 2, 2025
Merged
Conversation
nshapiro4
force-pushed
the
lsp-formatting
branch
4 times, most recently
from
0b354be to
c47f295
Compare
Jafaral
reviewed
Apr 24, 2025
Jafaral
reviewed
Apr 24, 2025
Jafaral
reviewed
Apr 24, 2025
Jafaral
reviewed
Apr 24, 2025
Jafaral
requested changes
Apr 24, 2025
Member
Jafaral
left a comment
Jafaral
left a comment
There was a problem hiding this comment.
Looks good overall. One formatting suggestion to improve readability of code.
It is much easier to read
if cond then
expr
else
expr
than having it all on one line. The line also gets too long when it the expr is on the same line.
nshapiro4
force-pushed
the
lsp-formatting
branch
2 times, most recently
from
16bf3e5 to
0ef066e
Compare
Jafaral
reviewed
Apr 24, 2025
Jafaral
reviewed
Apr 24, 2025
nshapiro4
force-pushed
the
lsp-formatting
branch
from
0ef066e to
e5530ae
Compare
Jafaral
approved these changes
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes general bug fixes