initial security considerations section. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+292
to
295
| To protect against attacks against their system, implementors of aipref parsing | ||
| and matching logic should take the following considerations into account: memory | ||
| management, invalid characters and parsing untrusted content. | ||
|
|
There was a problem hiding this comment.
This is helpful, but I think that you can refer to the security considerations of RFC 9651 for most of this. We might also want to specifically allow for a smaller limit than RFC 9651 requires for various things. If we think that the grammar is likely to be small, having a dictionary with 1024 key/value pairs might be excessive, just as tokens of 512 bytes are higher than the ONE we admit (for values). 256 parameters might be easy if they are going to be ignored, but that's still an awful lot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.