nginx: Fix default configuration for better performance - #97
Open
harimishal1 wants to merge 1 commit into
Open
Conversation
Change error_log level from debug to error. Debug-level logging generates excessive I/O under load, and is not appropriate as a default for the example application. Increase worker_connections from 32 to 128 to provide adequate headroom for concurrent connection benchmarks. Signed-off-by: misharu <harimishal1@gmail.com>
There was a problem hiding this comment.
Pull request overview
Updates the default Nginx configuration to improve performance.
Changes:
- Reduces error logging from
debugtoerror. - Increases
worker_connectionsfrom 32 to 128.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default nginx.conf in the nginx catalog-core app has two issues:
error_log logs/error.log debug— debug-level logging generates excessive I/O under load. Changed to error level, which still logs actual errors but doesn't flood the output during normal operation.worker_connections 32— this is nearly exhausted by a typical 30-connection benchmark. Increased to 128 to provide reasonable headroom.Related to #77. The deeper cause of the alternating throughput issue (
TIME_WAIT accumulation in lwIP) is addressed in a separate PR to lib-lwip.