Repository navigation
test(arch): Add unit tests for arch package - #2703
Closed
adity1raut wants to merge 3 commits into
Closed
adity1raut wants to merge 3 commits into
adity1raut wants to merge 3 commits into
Conversation
added 2 commits
March 9, 2026 19:59
Signed-off-by: adity1raut <araut7798@gmail.com>
…verage Signed-off-by: adity1raut <araut7798@gmail.com>
craciunoiuc
approved these changes
Mar 9, 2026
craciunoiuc
left a comment
Member
There was a problem hiding this comment.
All good here. Thanks!
Reviewed-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.com
Approved-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.com
nderjung
requested changes
Mar 9, 2026
nderjung
left a comment
Member
There was a problem hiding this comment.
Please see our contributing guidelines for code and commit conventions.
Author
I read once again, sorry for that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
Description of changes
Summary
unikraft/archpackageFunctions tested
ArchitectureName.String,ArchitectureByName,ArchitecturesByNameArchitectures,ArchitectureAliasesNewArchitectureFromSchema— empty string error + valid nameArchitectureConfigaccessors: Name, String, Source, Version, Type, PathIsUnpacked— existing dir, non-existent path, empty pathKConfig— correct CONFIG_ARCH_* key for x86_64, arm64, arm, unknownMarshalYAML,KConfigTree,PrintInfoTransformFromSchema— string, invalid type, with UK_BASE contextHostArchitecture— current host archNote
host.goreaches 60% coverage — thearm/defaultbranches ofHostArchitectureare platform-specific and cannot be tested on amd64.Related Issue
Closes #2702
Test plan
go test kraftkit.sh/unikraft/arch -cover— 97% coverage, all PASS