Repository navigation
chore(internal)!: Remove old node quirks - #2918
Merged
craciunoiuc merged 1 commit intoSep 9, 2026
Merged
Conversation
jedevc
reviewed
Sep 7, 2026
Signed-off-by: Cezar Craciunoiu <cezar@unikraft.io>
craciunoiuc
force-pushed
the
craciunoiuc/remove-old-node-quirks
branch
from
September 9, 2026 09:10
47dd4ac to
2b4d861
Compare
craciunoiuc
changed the title
jedevc
approved these changes
Sep 9, 2026
jedevc
left a comment
jedevc
left a comment
Member
There was a problem hiding this comment.
🔥 burn the quirks 🔥
Reviewed-by: Justin Chadwell <justin@unikraft.com>
Approved-by: Justin Chadwell <justin@unikraft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
Description of changes
This PR removes the quirks we did to accommodate for both new and old nodes.
Now that the public nodes are updated we can remove them.
Without merging this, propagation will now fail on the public nodes I believe, breaking deploys.
Depends-on:fra0being completely deprecated. This blocks only a release.Actually people can use the previous version for that old node.
Closes: TOOL-712