Repository navigation
test(e2e): Add e2e coverage for kraft system - #2929
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The list/unset coverage can pass without verifying expected list output.
Review effort: Lite
Findings: None
What changed in this PR
Adds 21 end-to-end tests for kraft system set, list, and unset commands.
Changes:
- Tests persistence, overwrites, removal, validation errors, and help output.
- Covers regression behavior for deleted keys.
- The list/unset test should assert known output before checking absence.
| File | Description |
|---|---|
test/e2e/cli/system_test.go |
Adds 21 CLI end-to-end specifications. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
craciunoiuc
requested changes
Sep 29, 2026
craciunoiuc
left a comment
craciunoiuc
left a comment
Member
There was a problem hiding this comment.
Hey
could you remove these comments?
Otherwise pretty good to go
Signed-off-by: srinivasr <sriniv4sreddy@gmail.com>
srinivasr
force-pushed
the
test/e2e-kraft-system
branch
from
September 29, 2026 14:23
0855fa3 to
eb38a75
Compare
Contributor
Author
done, removed both comment blocks, no other changes |
craciunoiuc
approved these changes
Sep 29, 2026
craciunoiuc
left a comment
craciunoiuc
left a comment
Member
There was a problem hiding this comment.
All good here. Thanks!
Reviewed-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.com>
Approved-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
Description of changes
Ref: #370
Adds e2e tests for kraft system set, list and unset in test/e2e/cli/system_test.go (21 specs).
set covers single and multiple keys, overwrites, and keeps existing keys. list checks the key=value output line by line since map order is random. unset checks the key is gone from the file and from list, other keys survive, and a removed key does not come back after a later set - that guards the bug from #2901, fixed in #2907. Also error cases (missing =, unknown keys, bad bool value, wrong arg counts) and --help output for the three subcommands.
Testing
ginkgo --focus "kraft system" test/e2e/cli/ - 21 passed, 0 failed, serial and parallel/random. gofumpt, vet and make lint clean.
Note: system unset on a scalar like log.level resets it to "" instead of the default. Left out of the assertions - happy to open an issue if that's unintended.