Skip to content

refactor!: Remove the kraft cloud subcommands #2937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
craciunoiuc wants to merge 6 commits into
base: staging
Choose a base branch
from
Draft

refactor!: Remove the kraft cloud subcommands #2937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
38a1e29
test(e2e): Remove Unikraft Cloud e2e suite
craciunoiuc Sep 30, 2026
8d5fbe8
refactor(pkg)!: Remove cloud metro and token flags
craciunoiuc Sep 30, 2026
dfd8e2f
refactor(cli): Move output format check to utils
craciunoiuc Sep 30, 2026
95d2cfd
feat(cloud)!: Replace kraft cloud with a stub
craciunoiuc Sep 30, 2026
a8221b2
refactor(config)!: Remove Unikraft Cloud auth
craciunoiuc Sep 30, 2026
b35e675
docs(README): Remove cloud deploy feature
craciunoiuc Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 0 additions & 57 deletions .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,60 +161,3 @@ jobs:
KRAFTKIT_DATA_DIR: /tmp/kraftkit-data
KRAFTKIT_STATE_DIR: /tmp/kraftkit-state
run: make test-e2e DISTDIR="$(go env GOPATH)"/bin

e2e-cloud-cli:
strategy:
fail-fast: false
matrix:
os:
- ubuntu-24.04

runs-on: ${{ matrix.os }}

steps:
- uses: actions/checkout@v7
with:
fetch-depth: 0
submodules: recursive

- name: Set up Go
uses: actions/setup-go@v7
with:
go-version: 1.26.5
cache: false

- name: Set Go variables
id: goenv
run: |
{
echo "cache=$(go env GOCACHE)"
echo "modcache=$(go env GOMODCACHE)"
echo "mod=$(go env GOMOD)"
} >>"$GITHUB_OUTPUT"

- name: Go caches
uses: actions/cache@v5
with:
path: |
${{ steps.goenv.outputs.cache }}
${{ steps.goenv.outputs.modcache }}
key: ${{ github.job }}-${{ runner.os }}-go-${{ hashFiles(steps.goenv.outputs.mod) }}
restore-keys: |
${{ github.job }}-${{ runner.os }}-go-

- name: Run framework unit tests
env:
KRAFTKIT_NO_WARN_SUDO: true
KRAFTKIT_NO_CHECK_UPDATES: true
DOCKER: ''
run: make test-framework DISTDIR="$(go env GOPATH)"/bin

- name: Run cloud e2e tests
env:
KRAFTCLOUD_METRO: ${{ secrets.KRAFTCLOUD_METRO }}
KRAFTCLOUD_TOKEN: ${{ secrets.KRAFTCLOUD_TOKEN }}
KRAFTCLOUD_USER: ${{ env.KRAFTCLOUD_USER }}
KRAFTKIT_NO_CHECK_UPDATES: true
KRAFTKIT_NO_WARN_SUDO: true
DOCKER: ''
run: make test-cloud-e2e DISTDIR="$(go env GOPATH)"/bin
6 changes: 1 addition & 5 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ lint: ## Lint all files according to linting preferences.
cicheck: lint ## Run CI checks.

.PHONY: test
test: test-unit test-framework test-e2e test-cloud-e2e ## Run all tests.
test: test-unit test-framework test-e2e ## Run all tests.

.PHONY: test-unit
test-unit: GOTEST_EXCLUDE := third_party/ test/ hack/ buildenvs/ dist/ docs/ tools/
Expand All @@ -276,10 +276,6 @@ test-e2e: kraft ## Run CLI end-to-end tests.
test-framework: kraft ## Run framework tests.
$(GINKGO) -v -p -randomize-all ./test/e2e/framework/...

.PHONY: test-cloud-e2e
test-cloud-e2e: ## Run cloud end-to-end tests.
$(GINKGO) -v -randomize-all --flake-attempts 2 --nodes 8 ./test/e2e/cloud/...

.PHONY: clean
clean:
$(GO) clean -modcache -cache -i -r
Expand Down
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ There are many benefits in running your application as a unikernel: for more inf
- 📚 Fetch and run pre-built unikernel from the [app catalog](https://github.com/unikraft/catalog);
- 🔥 Run unikernel VMs using QEMU, Xen and [Firecracker MicroVM](https://firecracker-microvm.github.io/);
- 🤹‍♀️ Daemonless unikernel local VM instance manager;
- ⛅️ Deploy unikernel VMs to the [cloud](https://unikraft.cloud);
- 🍎 Native Linux, macOS and Windows support;
- 📦 Package and push unikernels in OCI format for easy distribution;
- 🚜 ELF binary / POSIX-compatibility support;
Expand Down
1 change: 0 additions & 1 deletion config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ type KraftKit struct {
NoCheckUpdates bool `yaml:"no_check_updates" env:"KRAFTKIT_NO_CHECK_UPDATES" long:"no-check-updates" usage:"Do not check for updates" default:"false"`
NoColor bool `yaml:"no_color" env:"KRAFTKIT_NO_COLOR" long:"no-color" usage:"Disable color output"`
NoWarnSudo bool `yaml:"no_warn_sudo" env:"KRAFTKIT_NO_WARN_SUDO" long:"no-warn-sudo" usage:"Do not warn on running via sudo" default:"false"`
NoWarnCloudDeprecation bool `yaml:"no_warn_cloud_deprecation" env:"KRAFTKIT_NO_WARN_CLOUD_DEPRECATION" long:"no-warn-cloud-deprecation" usage:"Do not warn about kraft cloud subcommand deprecation" default:"false"`
Editor string `yaml:"editor" env:"KRAFTKIT_EDITOR" long:"editor" usage:"Set the text editor to open when prompt to edit a file"`
GitProtocol string `yaml:"git_protocol" env:"KRAFTKIT_GIT_PROTOCOL" long:"git-protocol" usage:"Preferred Git protocol to use" default:"https"`
Pager string `yaml:"pager,omitempty" env:"KRAFTKIT_PAGER" long:"pager" usage:"System pager to pipe output to" default:"cat"`
Expand Down
137 changes: 0 additions & 137 deletions config/kraftcloud.go
View file
Open in desktop

This file was deleted.

6 changes: 1 addition & 5 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,7 @@ require (
github.com/gobwas/glob v0.2.3
github.com/google/go-containerregistry v0.22.0
github.com/google/go-github/v32 v32.1.0
github.com/google/go-github/v39 v39.2.0
github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510
github.com/google/uuid v1.6.0
github.com/hbollon/go-edlib v1.7.0
github.com/henvic/httpretty v0.2.0
github.com/klauspost/cpuid/v2 v2.4.0
Expand Down Expand Up @@ -89,10 +87,8 @@ require (
k8s.io/apimachinery v0.36.3
k8s.io/apiserver v0.36.3
oras.land/oras-go/v2 v2.6.2
sdk.kraft.cloud v0.6.1
sigs.k8s.io/kustomize/kyaml v0.21.1
sigs.k8s.io/yaml v1.6.0
unikraft.com/cloud/sdk v0.3.0
unikraft.com/x/kraftfile v0.0.0-20260813011014-92d613cc773b
xenbits.xenproject.org/git-http/xen.git/tools/golang/xenlight v0.0.0-20240729172045-026c9fa29716
)
Expand Down Expand Up @@ -195,7 +191,6 @@ require (
github.com/go-task/slim-sprig/v3 v3.0.0 // indirect
github.com/gofrs/flock v0.13.0 // indirect
github.com/gogo/protobuf v1.3.2 // indirect
github.com/goharbor/go-client v0.213.1 // indirect
github.com/golang/groupcache v0.0.0-20241129210726-2c02b8208cf8 // indirect
github.com/golang/protobuf v1.5.4 // indirect
github.com/golang/snappy v1.0.0 // indirect
Expand All @@ -204,6 +199,7 @@ require (
github.com/google/go-cmp v0.7.0 // indirect
github.com/google/go-querystring v1.2.0 // indirect
github.com/google/pprof v0.0.0-20260802141513-ef3492d7dac3 // indirect
github.com/google/uuid v1.6.0 // indirect
github.com/grpc-ecosystem/grpc-gateway/v2 v2.30.0 // indirect
github.com/hashicorp/errwrap v1.1.0 // indirect
github.com/hashicorp/go-multierror v1.1.1 // indirect
Expand Down
11 changes: 0 additions & 11 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,8 +649,6 @@ github.com/gogo/protobuf v1.3.0/go.mod h1:SlYgWuQ5SjCEi6WLHjHCa1yvBfUnHcTbrrZtXP
github.com/gogo/protobuf v1.3.1/go.mod h1:SlYgWuQ5SjCEi6WLHjHCa1yvBfUnHcTbrrZtXPKa29o=
github.com/gogo/protobuf v1.3.2 h1:Ov1cvc58UF3b5XjBnZv7+opcTcQFZebYjWzi34vdm4Q=
github.com/gogo/protobuf v1.3.2/go.mod h1:P1XiOD3dCwIKUDQYPy72D8LYyHL2YPYrpS2s69NZV8Q=
github.com/goharbor/go-client v0.213.1 h1:bohLwNog8uv8FKhIZ0SHiaDbYr3X/1hovgo5fqZWMdo=
github.com/goharbor/go-client v0.213.1/go.mod h1:XMWHucuHU9VTRx6U6wYwbRuyCVhE6ffJGRjaeo0nvwo=
github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b/go.mod h1:SBH7ygxi8pfUlaOkMMuAQtPIUF8ecWP5IEl/CR7VP2Q=
github.com/golang/groupcache v0.0.0-20160516000752-02826c3e7903/go.mod h1:cIg4eruTrX1D+g88fzRXU5OdNfaM+9IcxsU14FzY7Hc=
github.com/golang/groupcache v0.0.0-20190129154638-5b532d6fd5ef/go.mod h1:cIg4eruTrX1D+g88fzRXU5OdNfaM+9IcxsU14FzY7Hc=
Expand Down Expand Up @@ -712,10 +710,7 @@ github.com/google/go-containerregistry v0.22.0 h1:eGbCiPeYxAH/7WLLq6zTBALP0tUIFs
github.com/google/go-containerregistry v0.22.0/go.mod h1:bJR35SK8XgisYmhg/FMQ/5RK0S/XrOAqLBV5/LR2XE0=
github.com/google/go-github/v32 v32.1.0 h1:GWkQOdXqviCPx7Q7Fj+KyPoGm4SwHRh8rheoPhd27II=
github.com/google/go-github/v32 v32.1.0/go.mod h1:rIEpZD9CTDQwDK9GDrtMTycQNA4JU3qBsCizh3q2WCI=
github.com/google/go-github/v39 v39.2.0 h1:rNNM311XtPOz5rDdsJXAp2o8F67X9FnROXTvto3aSnQ=
github.com/google/go-github/v39 v39.2.0/go.mod h1:C1s8C5aCC9L+JXIYpJM5GYytdX52vC1bLvHEF1IhBrE=
github.com/google/go-querystring v1.0.0/go.mod h1:odCYkC5MyYFN7vkCjXpyrEuKhc/BUO6wN/zVPAxq5ck=
github.com/google/go-querystring v1.1.0/go.mod h1:Kcdr2DB4koayq7X8pmAG4sNG59So17icRSOU623lUBU=
github.com/google/go-querystring v1.2.0 h1:yhqkPbu2/OH+V9BfpCVPZkNmUXhb2gBxJArfhIxNtP0=
github.com/google/go-querystring v1.2.0/go.mod h1:8IFJqpSRITyJ8QhQ13bmbeMBDfmeEJZD5A0egEOmkqU=
github.com/google/gofuzz v1.0.0/go.mod h1:dBl0BpW6vV/+mYPU4Po3pmUjxk6FQPldtuIdl/M65Eg=
Expand Down Expand Up @@ -1376,7 +1371,6 @@ golang.org/x/crypto v0.0.0-20200728195943-123391ffb6de/go.mod h1:LzIPMQfyMNhhGPh
golang.org/x/crypto v0.0.0-20201002170205-7f63de1d35b0/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto=
golang.org/x/crypto v0.0.0-20201216223049-8b5274cf687f/go.mod h1:jdWPYTVW3xRLrWPugEBEK3UY2ZEsg3UU495nc5E+M+I=
golang.org/x/crypto v0.0.0-20210322153248-0c34fe9e7dc2/go.mod h1:T9bdIzuCu7OtxOm1hfPfRQxPLYneinmdGuTeoZ9dtd4=
golang.org/x/crypto v0.0.0-20210817164053-32db794688a5/go.mod h1:GvvjBRRGRdwPK5ydBHafDWAxML/pGHZbMvKqRZ5+Abc=
golang.org/x/crypto v0.0.0-20210921155107-089bfa567519/go.mod h1:GvvjBRRGRdwPK5ydBHafDWAxML/pGHZbMvKqRZ5+Abc=
golang.org/x/crypto v0.0.0-20220622213112-05595931fe9d/go.mod h1:IxCIyHEi3zRg3s0A5j5BB6A9Jmi73HwBIUl50j+osU4=
golang.org/x/crypto v0.55.0 h1:+KWHjbgOaAQ66dh/YlkZKHlz9ZUlq61AFirAR9ntP8M=
Expand Down Expand Up @@ -1656,7 +1650,6 @@ google.golang.org/appengine v1.4.0/go.mod h1:xpcJRLb0r/rnEns0DIKYYv+WjYCduHsrkT7
google.golang.org/appengine v1.5.0/go.mod h1:xpcJRLb0r/rnEns0DIKYYv+WjYCduHsrkT7/EB5XEv4=
google.golang.org/appengine v1.6.1/go.mod h1:i06prIuMbXzDqacNJfV5OdTW448YApPu5ww/cMBSeb0=
google.golang.org/appengine v1.6.5/go.mod h1:8WjMMxjGQR8xUklV/ARdw2HLXBOI7O7uCIDZVag1xfc=
google.golang.org/appengine v1.6.7/go.mod h1:8WjMMxjGQR8xUklV/ARdw2HLXBOI7O7uCIDZVag1xfc=
google.golang.org/cloud v0.0.0-20151119220103-975617b05ea8/go.mod h1:0H1ncTHf11KCFhTc/+EFRbzSCOZx+VUbRMk55Yv5MYk=
google.golang.org/genproto v0.0.0-20180817151627-c66870c02cf8/go.mod h1:JiN7NxoALGmiZfu7CAH4rXhgtRTLTxftemlI0sWmxmc=
google.golang.org/genproto v0.0.0-20190307195333-5fe7a883aa19/go.mod h1:VzzqZJRnGkLBvHegQrXjBqPurQTc5/KpmUdxsrq26oE=
Expand Down Expand Up @@ -1812,8 +1805,6 @@ pgregory.net/rapid v1.2.0/go.mod h1:PY5XlDGj0+V1FCq0o192FdRhpKHGTRIWBgqjDBTrq04=
rsc.io/binaryregexp v0.2.0/go.mod h1:qTv7/COck+e2FymRvadv62gMdZztPaShugOCi3I+8D8=
rsc.io/quote/v3 v3.1.0/go.mod h1:yEA65RcK8LyAZtP9Kv3t0HmxON59tX3rD+tICJqUlj0=
rsc.io/sampler v1.3.0/go.mod h1:T1hPZKmBbMNahiBKFy5HrXp6adAjACjK9JXDnKaTXpA=
sdk.kraft.cloud v0.6.1 h1:PkaDTbopoPLXU87+oId6zP1olMyl6Sv7RTWMb8pnDmA=
sdk.kraft.cloud v0.6.1/go.mod h1:p0K9kzqAvT05sZfiXF9GZI6s1ccQPYIbJwp+nPXLWws=
sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.0.14/go.mod h1:LEScyzhFmoF5pso/YSeBstl57mOzx9xlU9n85RGrDQg=
sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.0.15/go.mod h1:LEScyzhFmoF5pso/YSeBstl57mOzx9xlU9n85RGrDQg=
sigs.k8s.io/json v0.0.0-20250730193827-2d320260d730 h1:IpInykpT6ceI+QxKBbEflcR5EXP7sU1kvOlxwZh5txg=
Expand All @@ -1830,8 +1821,6 @@ sigs.k8s.io/yaml v1.1.0/go.mod h1:UJmg0vDUVViEyp3mgSv9WPwZCDxu4rQW1olrI1uml+o=
sigs.k8s.io/yaml v1.2.0/go.mod h1:yfXDCHCao9+ENCvLSE62v9VSji2MKu5jeNfTrofGhJc=
sigs.k8s.io/yaml v1.6.0 h1:G8fkbMSAFqgEFgh4b1wmtzDnioxFCUgTZhlbj5P9QYs=
sigs.k8s.io/yaml v1.6.0/go.mod h1:796bPqUfzR/0jLAl6XjHl3Ck7MiyVv8dbTdyT3/pMf4=
unikraft.com/cloud/sdk v0.3.0 h1:0rjaODp1y/E+R5p0Kq11iF55yaCIPMOU9u8VKET0x9Y=
unikraft.com/cloud/sdk v0.3.0/go.mod h1:S7aGf6JP7grJSG0i+cmePnuPkuRCEbfWy3vWKXksi44=
unikraft.com/x/kraftfile v0.0.0-20260813011014-92d613cc773b h1:+BUY96TfOWuMPD4ZAp7oXMqSZ1mvtGgnVpzGgorXmyw=
unikraft.com/x/kraftfile v0.0.0-20260813011014-92d613cc773b/go.mod h1:rrdur8cnsuQAITjmF1pnulam6rG9JD68ACokaVtxu3E=
xenbits.xenproject.org/git-http/xen.git/tools/golang/xenlight v0.0.0-20240729172045-026c9fa29716 h1:y52AcO4BZop/FrR523z47VCLFViGmMJqY21uL+FxXXI=
Expand Down
3 changes: 0 additions & 3 deletions initrd/dockerfile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,6 @@ var (
func init() {
for _, cmd := range []string{
"kraft build",
"kraft cloud compose build",
"kraft cloud compose up",
"kraft cloud deploy",
"kraft compose build",
"kraft compose up",
"kraft pkg",
Expand Down
48 changes: 0 additions & 48 deletions internal/cli/kraft/cloud/certificate/certificate.go
View file
Open in desktop

This file was deleted.

Loading
Loading