Skip to content

Conversation

@ELC
Copy link
Contributor

@ELC ELC commented May 24, 2025

No description provided.

@ELC ELC force-pushed the improve-compatibility-between-pyspark-and-pydantic branch 2 times, most recently from 7ff798c to d947876 Compare May 24, 2025 17:12
@ELC ELC marked this pull request as ready for review May 24, 2025 17:13
@ELC ELC changed the title fix(ci): add Pydantic V1 to tests in CI fix(ci): add Pydantic V1 to tests in CI - Fixes #1446 May 24, 2025
@ELC
Copy link
Contributor Author

ELC commented May 24, 2025

This PR is a continuation of #1447 to fix #1446.

I do have a couple of queries and improvements in mind but wanted to go with the bare minimum to fix the bug.

I do have an alternative implementation in mind where we can have a pyspark_base.py with a PySparkDataFrameBase with the relevant methods and let pyspark.py and pyspark_sql.py only be the definition which add the specific parent class Dataframe either coming from pyspark.sql or pyspark.pandas.

What are your thoughts on this @cosmicBboy?

- Implement tests for the integration between PySpark and Pydantic.
- Create sample schema models and validate data using Pydantic.

Signed-off-by: Ezequiel Leonardo Castaño <[email protected]>
@ELC ELC force-pushed the improve-compatibility-between-pyspark-and-pydantic branch from d947876 to b0cb60f Compare May 24, 2025 17:43
@codecov
Copy link

codecov bot commented May 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 80 lines in your changes missing coverage. Please review.

Project coverage is 20.65%. Comparing base (812b2a8) to head (b5815cf).
Report is 325 commits behind head on main.

Files with missing lines Patch % Lines
pandera/typing/pyspark_sql.py 0.00% 41 Missing ⚠️
pandera/typing/pyspark.py 0.00% 38 Missing ⚠️
pandera/api/pyspark/__init__.py 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (812b2a8) and HEAD (b5815cf). Click for more details.

HEAD has 47 uploads less than BASE
Flag BASE (812b2a8) HEAD (b5815cf)
48 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2006       +/-   ##
===========================================
- Coverage   94.28%   20.65%   -73.63%     
===========================================
  Files          91      135       +44     
  Lines        7013    10557     +3544     
===========================================
- Hits         6612     2181     -4431     
- Misses        401     8376     +7975     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

cosmicBboy and others added 8 commits June 1, 2025 01:18
Signed-off-by: cosmicBboy <[email protected]>
* Delete foo.txt

Signed-off-by: Deepyaman Datta <[email protected]>

* Delete new_example.py

Signed-off-by: Deepyaman Datta <[email protected]>

---------

Signed-off-by: Deepyaman Datta <[email protected]>
…s#2015)

* Fix typehint in unique_values_eq

Signed-off-by: Ahmet Zamanis <[email protected]>

* Fix typo in unique_values_eq docstring

Signed-off-by: Ahmet Zamanis <[email protected]>

---------

Signed-off-by: Ahmet Zamanis <[email protected]>
- Set `spark.sql.ansi.enabled` to False in Spark session
  fixtures to prevent SQL compatibility issues during tests.

Signed-off-by: Ezequiel Leonardo Castaño <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants