-
-
Notifications
You must be signed in to change notification settings - Fork 370
Avoid full materialization of levels in failing MultiIndex validations #2187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cosmicBboy
merged 12 commits into
unionai-oss:main
from
amerberg:expand_unique_failure_cases
Jan 6, 2026
Merged
Avoid full materialization of levels in failing MultiIndex validations #2187
cosmicBboy
merged 12 commits into
unionai-oss:main
from
amerberg:expand_unique_failure_cases
Jan 6, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2187 +/- ##
==========================================
+ Coverage 81.51% 83.90% +2.38%
==========================================
Files 137 137
Lines 10898 10631 -267
==========================================
+ Hits 8884 8920 +36
+ Misses 2014 1711 -303 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Adam Merberg <[email protected]>
Signed-off-by: Adam Merberg <[email protected]>
Signed-off-by: Adam Merberg <[email protected]>
Signed-off-by: Adam Merberg <[email protected]>
Signed-off-by: Adam Merberg <[email protected]>
1dc390d to
533803b
Compare
Signed-off-by: Adam Merberg <[email protected]>
Signed-off-by: Adam Merberg <[email protected]>
Signed-off-by: Adam Merberg <[email protected]>
Signed-off-by: Adam Merberg <[email protected]>
Signed-off-by: Adam Merberg <[email protected]>
Signed-off-by: Adam Merberg <[email protected]>
Signed-off-by: Adam Merberg <[email protected]>
cosmicBboy
approved these changes
Jan 6, 2026
Collaborator
|
thanks @amerberg ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #2118, which allowed us to avoid materializing full level values of MultiIndex levels for successful validation. That PR, however, fell back to full materialization upon hitting a schema error, to ensure that failure cases would be reported correctly. This PR extends the benefit of the optimization to failing validations by joining the failure_cases from the unique values to a lookup table to build the failure_cases for the full values.
This should be particularly beneficial for running validations that are expected to fail, such as validating against a union
DataFrame[Schema1] | DataFrame[Schema2] | DataFrame[Schema3]where any given dataframe is only expected to conform to one of the schemas.