Support the Decimal data type in the Ibis engine
#2194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Deepyaman Datta <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2194 +/- ##
==========================================
- Coverage 83.86% 83.81% -0.06%
==========================================
Files 137 137
Lines 10607 10648 +41
==========================================
+ Hits 8896 8925 +29
- Misses 1711 1723 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Deepyaman Datta <[email protected]>
Signed-off-by: Deepyaman Datta <[email protected]>
deepyaman
force-pushed
the
feat/ibis/decimal-dtype
branch
from
235b323 to
3b3ebf6
Compare
Signed-off-by: Deepyaman Datta <[email protected]>
Signed-off-by: Deepyaman Datta <[email protected]>
deepyaman
force-pushed
the
feat/ibis/decimal-dtype
branch
from
31a5fdb to
aba77a6
Compare
deepyaman
changed the title
Decimal data type in the Ibis engine
deepyaman
commented
Jan 6, 2026
| self.sample_numeric_data, "float64" | ||
| ), | ||
| }, | ||
| # TODO(deepyaman): Identify bugs with decimal comparison |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| # TODO(deepyaman): Identify bugs with decimal comparison |
Signed-off-by: Deepyaman Datta <[email protected]>
deepyaman
force-pushed
the
feat/ibis/decimal-dtype
branch
from
aba77a6 to
ff4a2aa
Compare
cosmicBboy
approved these changes
Jan 6, 2026
| "datatype": dt.Float64, | ||
| "data": self.convert_data(self.sample_numeric_data, "float64"), | ||
| }, | ||
| # TODO(deepyaman): Enable once the decimal issue is resolved |
Collaborator
There was a problem hiding this comment.
hey @deepyaman can you make an issue for this? (or is this an ibis issue?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2185
Summary
merged/released. (Update: I installed Ibis offmain, undid the workarounds in tests/ibis/test_ibis_builtin_checks.py, and everything works; just need to update this once the new Ibis release is out then.)