Decouple import dependencies for io serialization formats #2195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decouple dependencies among different serialization backends for DataFrameSchema. This way, DataFrameSchema.to_json() will work with no additional dependencies. Fixes #2178
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2195 +/- ##
=======================================
Coverage 83.86% 83.87%
=======================================
Files 137 137
Lines 10607 10617 +10
=======================================
+ Hits 8896 8905 +9
- Misses 1711 1712 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cosmicBboy
changed the title
Signed-off-by: cosmicBboy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@azjps sorry I messed up your fork and PR: #2179, I have the changes you made with some additional fixes I was working on.