Unify builtin comparison checks with Narwhals impl - #2207
Draft
deepyaman wants to merge 2 commits into
Draft
Conversation
deepyaman
force-pushed
the
refactor/narwhalify
branch
from
January 20, 2026 06:28
ce7208a to
6002ae9
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2207 +/- ##
===========================================
- Coverage 83.76% 64.42% -19.34%
===========================================
Files 137 137
Lines 10715 10750 +35
===========================================
- Hits 8975 6926 -2049
- Misses 1740 3824 +2084 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
deepyaman
force-pushed
the
refactor/narwhalify
branch
2 times, most recently
from
January 20, 2026 07:12
b573161 to
cf33669
Compare
Refactor builtin check implementations for Polars to use Narwhals as a common abstraction layer, enabling code sharing between backends. This change implements equal_to, not_equal_to, greater_than, greater_than_or_equal_to, less_than, and less_than_or_equal_to checks using Narwhals. - Add narwhals dependency to polars and ibis optional dependency groups - Add CheckData protocol with frame and key properties for type safety - Add frame property to PolarsData and IbisData for uniform access - Replace NotImplementedError stubs in base with Narwhals implementations - Update Polars backend to delegate to base implementations - Ibis backend unchanged (keeps timedelta preprocessing) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
deepyaman
force-pushed
the
refactor/narwhalify
branch
from
January 20, 2026 07:13
cf33669 to
f873f5a
Compare
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
deepyaman
force-pushed
the
refactor/narwhalify
branch
from
January 20, 2026 07:32
e96847e to
43f3435
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor builtin check implementations for Polars and Ibis to use Narwhals as a common abstraction layer, enabling code sharing between backends. This change implements equal_to, not_equal_to, greater_than, greater_than_or_equal_to, less_than, and less_than_or_equal_to checks using Narwhals.