Add getTotalCredit() to UnionLens#185
Open
maxweng wants to merge 1 commit into
Open
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #185 +/- ##
==========================================
- Coverage 88.06% 87.38% -0.69%
==========================================
Files 21 21
Lines 1274 1284 +10
Branches 179 179
==========================================
Hits 1122 1122
- Misses 151 161 +10
Partials 1 1 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+166
to
+176
| function getTotalCredit(address underlying, address borrower) external view returns (uint256 total) { | ||
| IUserManager userManager = IUserManager(marketRegistry.userManagers(underlying)); | ||
|
|
||
| uint256 voucherCount = userManager.getVoucherCount(borrower); | ||
| for (uint256 i = 0; i < voucherCount; i++) { | ||
| (address staker, uint96 trust, , ) = userManager.vouchers(borrower, i); | ||
| (, uint96 stakedAmount, , , , ) = userManager.stakers(staker); | ||
| total += _min(stakedAmount, trust); | ||
| } | ||
| return decimalReducing(total, userManager.stakingTokenDecimal()); | ||
| } |
Check warning
Code scanning / Slither
Unused return
Comment on lines
+166
to
+176
| function getTotalCredit(address underlying, address borrower) external view returns (uint256 total) { | ||
| IUserManager userManager = IUserManager(marketRegistry.userManagers(underlying)); | ||
|
|
||
| uint256 voucherCount = userManager.getVoucherCount(borrower); | ||
| for (uint256 i = 0; i < voucherCount; i++) { | ||
| (address staker, uint96 trust, , ) = userManager.vouchers(borrower, i); | ||
| (, uint96 stakedAmount, , , , ) = userManager.stakers(staker); | ||
| total += _min(stakedAmount, trust); | ||
| } | ||
| return decimalReducing(total, userManager.stakingTokenDecimal()); | ||
| } |
Check warning
Code scanning / Slither
Unused return
Add getTotalCredit() to UnionLens
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.