Add RAW_P2TR address type with signing capability#17
Open
dannydeezy wants to merge 2 commits intounisat-wallet:masterfrom
Open
Add RAW_P2TR address type with signing capability#17dannydeezy wants to merge 2 commits intounisat-wallet:masterfrom
dannydeezy wants to merge 2 commits intounisat-wallet:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A proposed update to solve this: #16
By the way, I know this is not the proper way to do taproot addresses, but it's just an unfortunate mistake I made in the early ordinals days and we need to be able to recover assets on this type of address
As a follow up, we would add the address type here: https://github.com/unisat-wallet/extension/blob/e2fecaacf1e12d7879187d08b94914251f99f58f/src/shared/types.ts#L10
And then add an option when creating a Single Key wallet to use the new address type